Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: configurable keybindings #39

Open
infokiller opened this issue Jun 15, 2019 · 6 comments
Open

Feature request: configurable keybindings #39

infokiller opened this issue Jun 15, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@infokiller
Copy link

infokiller commented Jun 15, 2019

This can be done similarly to https://github.com/infokiller/web-search-navigator by adding an options page and storing the options in browser.sync.

Happy to send a PR if you are open to merging.

Related HN comment: https://news.ycombinator.com/item?id=20189188

Thanks!

@plibither8
Copy link
Owner

plibither8 commented Jun 15, 2019

Hi! This seems like a good idea :)

By adding a separate options page that is different from the popup page, we will have two places where one sets the extension settings, which doesn't look too good. All settings/options regarding the extension should be at one place only - either the popup or the options page.

Could you explain a bit more on how you will implement this in the code? Or better still, if you could create the PR, I can look at the code then and we can discuss about it.

Nevertheless, this is a nice enhancement which I'll be happy to look into.

Cheers!

@plibither8 plibither8 added ✨ Feature request Requests for new features enhancement New feature or request and removed ✨ Feature request Requests for new features labels Jun 15, 2019
@infokiller
Copy link
Author

Oh I wasn't aware of the pop up page, yes it definitely makes sense to add the customizations to that page.
Great, will send a PR soon.

@plibither8
Copy link
Owner

Great!

@plibither8
Copy link
Owner

Hey @infokiller, any updates regarding this?

@infokiller
Copy link
Author

Sorry, didn't get to this yet... Hope to do it soon

@plibither8
Copy link
Owner

Alright!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants