-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: configurable keybindings #39
Comments
Hi! This seems like a good idea :) By adding a separate options page that is different from the popup page, we will have two places where one sets the extension settings, which doesn't look too good. All settings/options regarding the extension should be at one place only - either the popup or the options page. Could you explain a bit more on how you will implement this in the code? Or better still, if you could create the PR, I can look at the code then and we can discuss about it. Nevertheless, this is a nice enhancement which I'll be happy to look into. Cheers! |
Oh I wasn't aware of the pop up page, yes it definitely makes sense to add the customizations to that page. |
Great! |
Hey @infokiller, any updates regarding this? |
Sorry, didn't get to this yet... Hope to do it soon |
Alright! |
This can be done similarly to https://github.com/infokiller/web-search-navigator by adding an options page and storing the options in
browser.sync
.Happy to send a PR if you are open to merging.
Related HN comment: https://news.ycombinator.com/item?id=20189188
Thanks!
The text was updated successfully, but these errors were encountered: