New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 4 conversion #76
Conversation
LGTM. Looks like we also need to update travis to new toolchain |
Sadly, I don't have merge permissions :( |
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
- Coverage 91.7% 90.37% -1.33%
==========================================
Files 46 46
Lines 4784 5686 +902
Branches 0 166 +166
==========================================
+ Hits 4387 5139 +752
- Misses 397 540 +143
- Partials 0 7 +7
Continue to review full report at Codecov.
|
FYI we need this ticket taken care of: plivesey/ConsistencyManager#58 so we can update the pod in this repo and do the merge. Otherwise it'll cause issues. |
I've now been given merge permissions and will be the maintainer going forward. I'm going to merge this now, run some more tests, and then release a new podspec. Thanks for your help on this. |
No description provided.