Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 4 conversion #76

Merged
merged 5 commits into from Feb 12, 2018
Merged

Swift 4 conversion #76

merged 5 commits into from Feb 12, 2018

Conversation

KashishGoel
Copy link
Contributor

No description provided.

@plivesey
Copy link
Owner

LGTM. Looks like we also need to update travis to new toolchain

@plivesey
Copy link
Owner

Sadly, I don't have merge permissions :(

@codecov-io
Copy link

Codecov Report

Merging #76 into master will decrease coverage by 1.32%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage    91.7%   90.37%   -1.33%     
==========================================
  Files          46       46              
  Lines        4784     5686     +902     
  Branches        0      166     +166     
==========================================
+ Hits         4387     5139     +752     
- Misses        397      540     +143     
- Partials        0        7       +7
Impacted Files Coverage Δ
RocketDataTests/BatchListenerTests.swift 97.5% <0%> (-0.72%) ⬇️
RocketData/ParsingHelpers.swift 88.88% <0%> (-11.12%) ⬇️
...ncyManager/Protocols/ConsistencyManagerModel.swift 57.89% <0%> (-8.78%) ⬇️
...ConsistencyManager/DataStructures/Array+Weak.swift 72.41% <0%> (-7.59%) ⬇️
RocketData/ChangeTime.swift 95.23% <0%> (-4.77%) ⬇️
RocketDataTests/TestModels/ChildModel.swift 83.33% <0%> (-3.04%) ⬇️
RocketData/BatchDataProviderListener.swift 91.3% <0%> (-2.82%) ⬇️
...taProviderTests/ConsistencyDataProviderTests.swift 90.2% <0%> (-2.36%) ⬇️
RocketDataTests/ParsingHelpersTests.swift 77.27% <0%> (-2.1%) ⬇️
...Tests/ConsistencyCollectionDataProviderTests.swift 92.15% <0%> (-1.79%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5edeb88...e7dc930. Read the comment docs.

@KashishGoel
Copy link
Contributor Author

FYI we need this ticket taken care of: plivesey/ConsistencyManager#58

so we can update the pod in this repo and do the merge. Otherwise it'll cause issues.

@plivesey
Copy link
Owner

I've now been given merge permissions and will be the maintainer going forward.

I'm going to merge this now, run some more tests, and then release a new podspec.

Thanks for your help on this.

@plivesey plivesey merged commit eaf8fb3 into plivesey:master Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants