Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the ability to get remote static public key #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wdhongtw
Copy link

It's the application's responsibility to determine whether the remote party's static public key is acceptable, as the security consideration section stated in The Noise Protocol Framework. However, the current implementation does not provide the opportunity for application to examine the remote party's static public key.

Once the handshake process is done, the HandshakeState object is deleted, and this is also the recommended behavior. Thus, in this PR, I try to reuse the keypairs field in NoiseProtocol object to record the keypairs which will be encountered during the handshake process, and provide a get_public_bytes interface to retrieve these keys.

The test for this new API is also provided in this PR.

@wdhongtw
Copy link
Author

Hi @plizonczyk , is there something I need to do for the CI flow? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant