Merge pull request astropy#15361 from meeseeksmachine/auto-backport-o…

…f-pr-15359-on-v5.3.x Backport PR astropy#15359 on branch v5.3.x (BUG: Close Gzipfile in votable/utils properly)
pllim · Sep 21, 2023 · 5753610 · 5753610
2 parents d4b0ede + 9753746
commit 5753610
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/astropy/io/votable/util.py b/astropy/io/votable/util.py
@@ -76,10 +76,12 @@ def convert_to_writable_filelike(fd, compressed=False):
 
         if needs_wrapper:
             yield codecs.getwriter("utf-8")(fd)
-            fd.flush()
         else:
             yield fd
-            fd.flush()
+
+        fd.flush()
+        if isinstance(fd, gzip.GzipFile):
+            fd.close()
 
         return
     else:

diff --git a/docs/changes/io.votable/15359.bugfix.rst b/docs/changes/io.votable/15359.bugfix.rst
@@ -0,0 +1 @@
+Fixed a bug in ``convert_to_writable_filelike`` where ``GzipFile`` was not closed properly.