-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow selecting GET/POST for forms #396
Conversation
Create an accessor for the FormMethod form field to handle Auto.
Or should it honour the form method?
Both for form and for any datagrid on the form.
We now have tests, 'Auto' by default, and datagrid method following form's method. @djay do we actually want to control datagrid's method, or should it always be |
It doesn't change anything serverside. Also give the datagrid script an id, can't hurt.
This shows how to do per-datagrid-field matching.
If it turns out we want tojson to sometimes POST, we can put it back.
OK, datagrids always |
Data grid should always be a get if its just reading. Same with hidewhen checks. |
Something to note: Is GET request length still an issue? If so, it also motivates |
This is the simplest way to be able to choose the AJAX method a form should use, e.g. if the AJAX calls need to use POST because of a very bulky form. It means that AJAX will sometimes use POST unnecessarily. We can revisit this later.
TODO: still need a test for computehidewhens
After more discussion with @djay: AJAX calls use the same method as the form they're on. |
Allow selecting GET/POST for forms
Forms get a dropdown for form method, defaulting to
POST
.Current tests pass, but I haven't written tests for
GET
forms yet.Don't merge yet.