Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG REPORT: Some nested section id="edit-bar" tag in folder_contents page #2322

Closed
terapyon opened this issue Mar 1, 2018 · 2 comments
Closed

BUG REPORT: Some nested section id="edit-bar" tag in folder_contents page #2322

terapyon opened this issue Mar 1, 2018 · 2 comments

Comments

@terapyon
Copy link
Member

terapyon commented Mar 1, 2018

BUG REPORT

What I did:

  • Click any fc-breadcrumbs on folder_contents page
  • And Re-Click the fc-breadcrumbs

What I expect to happen:

I think section id="edit-bar" tag will not be shown in dynamic html.

What actually happened:

section id="edit-bar" tag will be made too.
terapyon added a commit that referenced this issue Mar 1, 2018
@terapyon
[WIP] Fix: nested section id="edit-bar" tag
d122096 
Some nested `section id="edit-bar"` tag in folder_contents page #2322
@terapyon terapyon mentioned this issue Mar 1, 2018
Closed
terapyon added a commit that referenced this issue Mar 1, 2018
@terapyon
Some nested section id="edit-bar" tag in folder_contents page #2322
a3fb019
@terapyon terapyon mentioned this issue Mar 1, 2018
Merged
@gp54321 gp54321 mentioned this issue May 2, 2018
Closed
@gp54321
Copy link

gp54321 commented May 2, 2018

see #2395

thet added a commit that referenced this issue May 2, 2018
@thet
Revert "Some nested section id="edit-bar" tag in folder_contents page
ce44eca 
#2322"

This reverts commit a3fb019.
@thet thet mentioned this issue May 2, 2018
Merged
@thet thet reopened this Oct 3, 2018
@thet
Copy link
Member

thet commented Oct 3, 2018

The issue is still open.
But I have a fix for it...

thet added a commit to plone/plonetheme.barceloneta that referenced this issue Oct 3, 2018
@thet
Do not strip the #edit-bar section from the toolbar.
8beb307 
Refs: plone/Products.CMFPlone#2322
thet added a commit that referenced this issue Oct 3, 2018
@thet
Fix multiple nested #edit-bar section when navigating in folder conte…
d01e2c7 
…nts.

Fixes: #2322
This was referenced Oct 3, 2018
Merged
Merged
thet added a commit that referenced this issue Oct 4, 2018
@thet
Fix multiple nested #edit-bar section when navigating in folder conte…
16cd9a4 
…nts.

Fixes: #2322
@sunew sunew mentioned this issue Oct 4, 2018
Open
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Oct 4, 2018
@sunew
[fc] Repository: plonetheme.barceloneta
43a76db 
Branch: refs/heads/master
Date: 2018-10-03T23:33:24+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plonetheme.barceloneta@8beb307

Do not strip the #edit-bar section from the toolbar.
Refs: plone/Products.CMFPlone#2322

Files changed:
M CHANGES.rst
M plonetheme/barceloneta/theme/rules.xml
Repository: plonetheme.barceloneta

Branch: refs/heads/master
Date: 2018-10-04T15:35:50Z
Author: Sune Broendum Woeller (sunew) <sune@woeller.dk>
Commit: plone/plonetheme.barceloneta@2e2a652

Merge pull request #165 from plone/fix-2322

Do not strip the #edit-bar section from the toolbar.

Files changed:
M CHANGES.rst
M plonetheme/barceloneta/theme/rules.xml
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Oct 4, 2018
@sunew
[fc] Repository: plonetheme.barceloneta
fdb7531 
Branch: refs/heads/master
Date: 2018-10-03T23:33:24+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plonetheme.barceloneta@8beb307

Do not strip the #edit-bar section from the toolbar.
Refs: plone/Products.CMFPlone#2322

Files changed:
M CHANGES.rst
M plonetheme/barceloneta/theme/rules.xml
Repository: plonetheme.barceloneta

Branch: refs/heads/master
Date: 2018-10-04T15:35:50Z
Author: Sune Broendum Woeller (sunew) <sune@woeller.dk>
Commit: plone/plonetheme.barceloneta@2e2a652

Merge pull request #165 from plone/fix-2322

Do not strip the #edit-bar section from the toolbar.

Files changed:
M CHANGES.rst
M plonetheme/barceloneta/theme/rules.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thet @terapyon @gp54321