Skip to content

Commit

Permalink
plone.supermodel and plone.registry added to auto-checkout. plone.reg…
Browse files Browse the repository at this point in the history
…istry Choice field construction needs to accommodate optional use of SimpleVocabulary that can be converted into values to accommodate fix from plone/plone.supermodel@f16f480  -- plone.registry changes should be released prior or concurrent to plone.supermodel release.
  • Loading branch information
seanupton committed Jun 6, 2014
1 parent 4702b40 commit 7c8bbd5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions checkouts.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@ auto-checkout =
plone.outputfilters
plone.portlet.collection
plone.recipe.zope2instance
plone.registry
plone.resourceeditor
plone.schemaeditor
plone.supermodel
plonetheme.sunburst
Products.Archetypes
Products.CMFPlone
Expand Down

3 comments on commit 7c8bbd5

@mister-roboto
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=a90f84dedc5a48458e03d562467993ee
plone-4.3-python-2.6 [FAILURE]
plone-4.3-python-2.7 [SUCCESS]

@tisto
Copy link
Member

@tisto tisto commented on 7c8bbd5 Jun 7, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanupton This commit broke the Plone 4.3 - Python 2.6 build (39 test failures). Therefore I reverted it.

It seems those packages include tests that fail on Python 2.6 but pass on Python 2.7. Please fix those test failures and re-add the packages to auto-checkout (I already fixed the failing p.a.portlets test).

Next time you break the build, please revert your commit immediately, so other people can continue to work. See https://buildoutcoredev.readthedocs.org/en/latest/continous-integration.html for details.

@seanupton
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisto -- this is now green at http://jenkins.plone.org/job/plone-4.3-python-2.6/2138/. Sorry for the confusion and the regression -- it turns out that my original fix for the py26 regression in plone.supermodel was incomplete, and I was confused about that.

Please sign in to comment.