New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why does plone/documentation keep getting committed automatically? #768
Comments
As mentioned elsewhere this can be mitigated by adding:
But probably removing this hook might help. |
I will try to fix the sources right now and investigate more on this later CC @plone/testing-team |
🤔 I think is a mr.roboto feature, if a package that is listed in sources gets a new change but is not on checkouts, it adds it, so one can ensure that the new features that landed on a package get tested |
We can add an exception list on that functionality (if it actually works as I mentioned, which my not even be true 😅 ) |
I do not know why it was added or whether it should be preserved in some way. I now have access to the |
Also this is not urgent from my perspective or from that of the branch |
Indeed, there is such a functionality: https://github.com/plone/mr.roboto/blob/70e08fcab664a8db4e0749b92c6acca62288d46d/src/mr.roboto/src/mr/roboto/subscriber.py#L473 |
@gforcada I think you got it right but in the sources.cfg the repo is defined as:
In #769 I provide an alias for that. |
the question is, why is documentation on the checkouts? and if anyway it has to stay there, it does at least not have to make jenkins run again, right? 🤔 so we can add an exception list on the function on |
I think that somewhere here we could make some check that excludes the documentation repo: https://github.com/plone/mr.roboto/blob/70e08fcab664a8db4e0749b92c6acca62288d46d/src/mr.roboto/src/mr/roboto/subscriber.py#L459-L469 |
sure, why is it though that the documentation is checked alongside the code? 🤔 |
I have time to do that now, if somebody wants to join me on that, please ping me in discord |
Maybe it is needed for some other automation, IMO it is not that bad to have that in the |
@ale-rt if you can review this: plone/mr.roboto#91 👍🏾 |
Deployed to production, can someone test if my fix does work? 😄 |
We have a few WIP PRs. I'll let you know whether I get another alert after we merge the next one. |
I think it worked. This file was not updated. https://github.com/plone/buildout.coredev/blob/6.0/checkouts.cfg Is that what y'all were expecting? |
Not sure what to make of this email. Is it still a problem? POSSIBLE CHECKOUT ERROR plone/documentation 6-dev
|
That's a safe check to ensure that if something goes wrong you get a heads up about it |
Sorry for being ignorant. I'm new to this repo. I don't know what is "expected". How do I know what is "something goes wrong"? |
i.e. regular Plone packages are expected to be in a certain buildout.coredev branch, if a package is not check out it might miss the new changes being tested |
I keep breaking Jenkins with ever merge commit to the
6-dev
branch inplone/documentation
. Help! Make it stop!This file keeps getting updated:
https://github.com/plone/buildout.coredev/blob/6.0/checkouts.cfg
Example automatic commit:
75b42d6
The text was updated successfully, but these errors were encountered: