Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spellcheck #1190

Open
stevepiercy opened this issue Feb 21, 2022 · 6 comments
Open

Improve spellcheck #1190

stevepiercy opened this issue Feb 21, 2022 · 6 comments

Comments

@stevepiercy
Copy link
Contributor

stevepiercy commented Feb 21, 2022

It would be good to improve spellcheck and consistency of spellings. For example:

JavaScript, instead of javascript / Javascript / js
NodeJS, instead of nodejs / Node.js / node

Use caution when doing global find and replaces to not overwrite commands or code blocks that use those strings.

To improve spellcheck, add words to styles/Vocab/Plone/accept.txt and styles/Vocab/Plone/reject.txt.

See also:

Contributing

@chirayu-humar
Copy link

i observed that this issue is mentioned in a pull request named plone/plone.restapi-client#5, which is already merged so i want to conferm whether this issue is resolved now or i can start working on this ?

@stevepiercy
Copy link
Contributor Author

That issue is for a different repository and project. Spell checking can always be improved in this repository. Please feel free to work on improving the quality of spelling.

@chirayu-humar
Copy link

I am working on this issue

@chirayu-humar
Copy link

chirayu-humar commented Aug 4, 2023

i have generated a draft pull request but being honest and sorry to say but, i am little bit unsure that it will work properly because i have not tested it on my local system because i did knew where is this spell check is used further in codebase, to figure it out it will take some time.

@Akshat2Jain
Copy link
Member

@stevepiercy, plz close this issue as this is already solved

@stevepiercy
Copy link
Contributor Author

@Akshat2Jain no, there is a LOT more work to do. There are still hundreds of errors, warnings, and suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants