Update Vale custom vocabularies #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for 6-docs-plone-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
davisagli
reviewed
Aug 15, 2023
| [^.]js |
There was a problem hiding this comment.
I don't understand this one. Reject any 3 letter word ending in js unless the first character is a period?
There was a problem hiding this comment.
Close. It matches words that end with "not-dot" followed by "js". Then reject the matches.
Thus it will match "Nodejs" and reject it, as the correct spelling is "Node.js".
side rant: Let it be known that punctuation in your branding and identity is a stupid idea. Wal-Mart is now Walmart, after they learned their lesson from bad SEO.
davisagli
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
✖ 2066 errors, 1146 warnings and 4327 suggestions in 335 files.
After
✖ 1787 errors, 1146 warnings and 4323 suggestions in 335 files.
Nice! A 13.5% drop in errors.
See #1190, plone/volto#5095, and plone/volto#5056