Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the key to None when a NotYet error is raised #2

Merged
merged 1 commit into from
Aug 17, 2016
Merged

Conversation

ale-rt
Copy link
Member

@ale-rt ale-rt commented Jul 29, 2016

A NotYet exception is raised when the object has not a proper path.
In this case we do not want to update any reference to it.

@thet
Copy link
Member

thet commented Jul 30, 2016

Please add a changelog entry and a statement what this PR solves...

@ale-rt
Copy link
Member Author

ale-rt commented Aug 10, 2016

Sorry @thet! I completely forgot about this PR, thanks for reminding that to me :)
I hope I will be able to do this today :)

@frapell frapell merged commit c701eda into master Aug 17, 2016
@gforcada gforcada deleted the fix-not-yet branch August 17, 2016 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants