Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround to fix the path of moved objects #8

Merged
merged 2 commits into from
May 21, 2019

Conversation

ale-rt
Copy link
Member

@ale-rt ale-rt commented May 13, 2019

This PR wants to provide a workaround for the issue described in plone/plone.api#430.
The reason why this PR is needed is that moving an object does not actually updates the object stored in the intid persistent utility because the relevant BTrees do not recognize that the key is changed (probably because the computed __hash__ does not change).

Closes plone/plone.api#430

@mister-roboto
Copy link

@ale-rt thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@ale-rt
Copy link
Member Author

ale-rt commented May 13, 2019

@jenkins-plone-org please run jobs

@ale-rt
Copy link
Member Author

ale-rt commented May 13, 2019

@plone/release-team is it possible to activate the issue tracker? There are other issues that I think should be checked in this package:

@gforcada
Copy link
Sponsor Member

@ale-rt issues enabled, feel free to create new issues 👍

@ale-rt
Copy link
Member Author

ale-rt commented May 14, 2019

Thanks @gforcada!

@jensens jensens merged commit ad9f77f into master May 21, 2019
@jensens jensens deleted the workaround-to-fix-moved-objects branch May 21, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The intids catalog contains stale references after move operations
4 participants