This repository has been archived by the owner on Apr 9, 2023. It is now read-only.
Patternslib merge: Removed the Mockup registry in favor of Patternslib's #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This init method calls the constructor for the pattern and then initializes the return instance. This is Mockup specific and therefore shouldn't be done in the Patternslib registry.
signature to the Patternslib init method.
Useful when you're running the tests in a VM environment but still want to use a browser.
Patternslib will automatically turn the pattern into a jQuery pattern.
This allows the Patternslib registry code to be simpler by not having the differentiate between Patternslib patterns and Mockup patterns.
Also, extend the Makefile so that we can use the test-serve runner.
to better explain what's going on.
* Test for exceptions raised when required properties aren't provided. * Test that the init method is called. * Make sure the existing tests now conform with what the Patternslib registry expects.
The DOM parsing test will be moved to a new test module.
Same applies for patterns without a "trigger" attribute. This is done so that the TinyMCE patterns in links.js still work. However, I don't see why the code there should be wrapped in patterns, an eventual refactoring there is probably a good idea.
|
Looks fine. Feel free to merge whenever you want along with mockup. |
jcbrand
added a commit
that referenced
this pull request
Jan 26, 2015
Patternslib merge: Removed the Mockup registry in favor of Patternslib's
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is in connection with #460 and needs to be merged first before #460 can be merged.
Most details are provided in that pull request.
CC @vangheem