-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register bootstrap+jquery globally #1177
Conversation
@thet thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
cc53dd2
to
39ebbb9
Compare
39ebbb9
to
7cf9597
Compare
I've experimented with "eager sharing" option for the global modules... The main change here is, that there are no more "remote" modules my addons wich use Somehow /cc @maethu are you able to test this change here? |
NOTE: you have to disable |
1a6f349
to
0f094b5
Compare
UPDATE: when importing bootstrap with async/await, it's defined as expected: Lines 7 to 13 in a6b2dea
|
0f094b5
to
a6b2dea
Compare
Closed in favor of #1185 |
Awesome! I just tried it with #1185 - Seems to work really well. |
No description provided.