Uncomment realteditems tests #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rather than silently drop them, make a note of them to actually get that handled later.
- This patches up the test data with a function to add in the expected fields to not cause rendering errors. - Also included is the patch to search helper function with the dummy json provider to restore the search by folder functionality as per upgrade in Products.CMFCore. - Remove the skip designation for all affected tests within the relateditems pattern. Side note: - These "attributes" need to be really documented somewhere to either ensure third-party users can use this, or tell them not to.
|
Can you add a changelog entry? |
metatoaster
added a commit
that referenced
this pull request
Feb 11, 2016
|
If this changelog entry is needed even though this was done mostly for the XSS fix. If not just leave this be and purge this branch again. |
|
yah, sorry, I noticed the other changelog and forgot to mention this comment was no longer valid. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncommented tests for the relateditems pattern and corrected the issues in the test harness to make it work again.