Relateditems pattern XSS fix #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rather than silently drop them, make a note of them to actually get that handled later.
- This patches up the test data with a function to add in the expected fields to not cause rendering errors. - Also included is the patch to search helper function with the dummy json provider to restore the search by folder functionality as per upgrade in Products.CMFCore. - Remove the skip designation for all affected tests within the relateditems pattern. Side note: - These "attributes" need to be really documented somewhere to either ensure third-party users can use this, or tell them not to.
- Also for the structure selection well XSS fix.
metatoaster
changed the title
metatoaster
changed the title
|
Thanks for this. I will say, if we have XSS in our catalog results for urls and paths, we're have other issues... |
|
Yes, found this out while doing my own QA on #618. This was not a fun one for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The embedded template uses
<%= value %>for everything which enables XSS attack. Replaced all of this with<%- value %>and made a note for<%= item %>as that contains markup generated by the breadCrumbs template. Requires pull request #628 as I need all existing test to run because overzealous cleansing broke breadCrumbs, heh.As an aside, should better review be in place in the first place to actually not let tests be removed without proper explanation? Also maybe need some automated audit of the usage of the
<%= value %>syntax as part of the tests, because I don't like XSS in my CMS. Though this second part is a difficult requirement to address at the moment as I see it.