Make request arguments optional.

docs/CHANGES.rst

@@ -4,6 +4,9 @@ Changelog
 1.3.3 (unreleased)
 ------------------
 
+- Made the request argument optional.
+  [jaroel]
+
 - Make Products.Archetypes dependency optional. Fixes #197
   [jaroel]
 

docs/content.rst

@@ -358,11 +358,7 @@ To get a :class:`BrowserView` for your content, use :meth:`api.content.get_view`
 
     from plone import api
     portal = api.portal.get()
-    view = api.content.get_view(
-        name='plone',
-        context=portal['about'],
-        request=request,
-    )
+    view = api.content.get_view(name='plone', context=portal['about'])
 
 .. invisible-code-block: python
 

docs/portal.rst

@@ -184,7 +184,7 @@ With :meth:`api.portal.show_message` you can show a notification message to the
 .. code-block:: python
 
     from plone import api
-    api.portal.show_message(message='Blueberries!', request=request)
+    api.portal.show_message(message='Blueberries!')
 
 .. invisible-code-block: python
 

src/plone/api/content.py

@@ -14,6 +14,7 @@
 from zope.component import getMultiAdapter
 from zope.component import getSiteManager
 from zope.container.interfaces import INameChooser
+from zope.globalrequest import getRequest
 from zope.interface import Interface
 from zope.interface import providedBy
 
@@ -425,22 +426,25 @@ def transition(obj=None, transition=None, to_state=None):
             )
 
 
-@required_parameters('name', 'context', 'request')
+@required_parameters('name', 'context')
 def get_view(name=None, context=None, request=None):
     """Get a BrowserView object.
 
     :param name: [required] Name of the view.
     :type name: string
     :param context: [required] Context on which to get view.
     :type context: context object
-    :param request: [required] Request on which to get view.
+    :param request: Request on which to get view.
     :type request: request object
     :raises:
         :class:`~plone.api.exc.MissingParameterError`,
         :class:`~plone.api.exc.InvalidParameterError`
     :Example: :ref:`content_get_view_example`
     """
 
+    if request is None:
+        request = getRequest()
+
     try:
         return getMultiAdapter((context, request), name=name)
     except:

src/plone/api/portal.py

@@ -205,7 +205,7 @@ def get_localized_time(datetime=None, long_format=False, time_only=False):
     )
 
 
-@required_parameters('message', 'request')
+@required_parameters('message')
 def show_message(message=None, request=None, type='info'):
     """Display a status message.
 
@@ -219,6 +219,8 @@ def show_message(message=None, request=None, type='info'):
         ValueError
     :Example: :ref:`portal_show_message_example`
     """
+    if request is None:
+        request = getRequest()
     IStatusMessage(request).add(message, type=type)
 
 

src/plone/api/tests/test_content.py

@@ -708,13 +708,6 @@ def test_get_view_constraints(self):
                 request=request,
             )
 
-        # request is required
-        with self.assertRaises(MissingParameterError):
-            api.content.get_view(
-                name='plone',
-                context=self.blog,
-            )
-
     def test_get_view(self):
         """Test the view."""
         request = self.layer['request']
@@ -737,6 +730,12 @@ def test_get_view(self):
         self.assertEqual(view.__name__, 'plone_context_state')
         self.assertEqual(aq_base(view.canonical_object()), aq_base(self.blog))
 
+    def test_get_view_implicit_request(self):
+        """Test that get_view gets a request if none is passed in."""
+        request = self.layer['request']
+        view = api.content.get_view(name='plone', context=self.blog)
+        self.assertEqual(view.request, request)
+
     def test_get_uuid(self):
         """Test getting a content item's UUID."""
         from plone.api.exc import MissingParameterError

src/plone/api/tests/test_portal.py

@@ -347,13 +347,10 @@ def test_show_message_constraints(self):
         with self.assertRaises(MissingParameterError):
             portal.show_message()
 
-        # message and request are required
+        # message is required
         with self.assertRaises(MissingParameterError):
             portal.show_message(request=self.layer['request'])
 
-        with self.assertRaises(MissingParameterError):
-            portal.show_message(message='Beer is brewing.')
-
     def test_show_message(self):
         """Test to see if message appears."""
 
@@ -372,6 +369,16 @@ def test_show_message(self):
         self.assertEqual(show[0].message, 'One')
         self.assertEqual(show[1].message, 'Two')
 
+    def test_show_message_implicit_request(self):
+        from Products.statusmessages.interfaces import IStatusMessage
+        request = self.layer['request']
+
+        portal.show_message(message='Blueberries!')
+        messages = IStatusMessage(request)
+        show = messages.show()
+        self.assertEqual(len(show), 1)
+        self.assertIn('Blueberries!', show[0].message)
+
     def test_get_navigation_root(self):
         """Test to see if the navigation_root is returned."""