Merge pull request #321 from plone/fix-revoke-users

Fix an AttributeError in `api.user.revoke_roles`
plone · Oct 29, 2016 · 58e49e7 · 58e49e7 · jenkins-plone-org · Oct 29, 2016
2 parents 841f9a2 + 3a530d2
commit 58e49e7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/docs/CHANGES.rst b/docs/CHANGES.rst
@@ -5,6 +5,8 @@ Changelog
 ------------------
 
 Fixes:
+- Fix an AttributeError in `api.user.revoke_roles`
+  [ale-rt]
 
 - Remove print statements and use @security decorators to make
   code-analysis happy.

diff --git a/src/plone/api/user.py b/src/plone/api/user.py
@@ -408,7 +408,8 @@ def revoke_roles(username=None, user=None, obj=None, roles=None):
     if obj is not None:
         # if obj, get only a list of local roles, without inherited ones
         inherit = False
-    actual_roles = get_roles(user=user, obj=obj, inherit=inherit)
+
+    actual_roles = list(get_roles(user=user, obj=obj, inherit=inherit))
     if actual_roles.count('Anonymous'):
         actual_roles.remove('Anonymous')
     if actual_roles.count('Authenticated'):