Skip to content

Commit

Permalink
Re-added comma that I should not have removed.
Browse files Browse the repository at this point in the history
I thought flake8 complained about this line, but it apparently was a different one.
I wondered about this one.
When you revoke the ('Editor') roles, without comma, you revoke the role E, d, i, t, o, r.
Not what you want. :-)
('Editor',) works.  A list would work too.
  • Loading branch information
mauritsvanrees committed Feb 16, 2018
1 parent bd8d461 commit 7244364
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/plone/api/tests/test_user.py
Expand Up @@ -717,7 +717,7 @@ def test_revoke_roles(self):
self.assertIn('Editor', api.user.get_roles(username='chuck'))
self.assertIn('Editor', api.user.get_roles(user=user))

api.user.revoke_roles(username='chuck', roles=('Editor'))
api.user.revoke_roles(username='chuck', roles=('Editor',))
ROLES = ['Authenticated', 'Member']
self.assertItemsEqual(
ROLES,
Expand Down

0 comments on commit 7244364

Please sign in to comment.