Skip to content

Commit

Permalink
Match the code to the actual implementation in CMFCore.
Browse files Browse the repository at this point in the history
  • Loading branch information
@jaroel
jaroel committed Jul 20, 2015
1 parent 538985b commit 753db1c
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions src/plone/api/content.py
View file
Expand Up @@ -71,13 +71,11 @@ def create(

# Check if we are allowed to add type to container.
types_tool = portal.get_tool('portal_types')
try:
fti = types_tool[type]
except KeyError:
fti = types_tool.getTypeInfo(type)
if fti is None:
raise InvalidParameterError('No such content type: {0}'.format(type))
else:
if not fti.isConstructionAllowed(container):
raise Unauthorized()
elif not fti.isConstructionAllowed(container):
raise Unauthorized('Cannot create %s' % fti.getId())

# Create a temporary id if the id is not given
content_id = not safe_id and id or str(random.randint(0, 99999999))
Expand Down

5 comments on commit 753db1c

@gforcada
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaroel Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.api/13//violations

ERROR: /home/jenkins/workspace/package-plone.api@3/src/plone/api/content.py Imports are incorrectly sorted.
src/plone/api/content.py:0:1: I001 found unsorted imports
src/plone/api/content.py:78:43: S001 found %s formatter
src/plone/api/content.py:97:13: Q000 Remove bad quotes.
src/plone/api/content.py:98:13: Q000 Remove bad quotes.
src/plone/api/content.py:99:13: Q000 Remove bad quotes.
src/plone/api/content.py:310:1: C901 '_wf_transitions_for' is too complex (12)
src/plone/api/content.py:402:17: Q000 Remove bad quotes.
src/plone/api/content.py:403:17: Q000 Remove bad quotes.
src/plone/api/content.py:430:17: Q000 Remove bad quotes.
src/plone/api/content.py:469:13: Q000 Remove bad quotes.
src/plone/api/content.py:470:13: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api@3/src/plone/api/env.py Imports are incorrectly sorted.
src/plone/api/env.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.api@3/src/plone/api/portal.py Imports are incorrectly sorted.
src/plone/api/portal.py:0:1: I001 found unsorted imports
src/plone/api/portal.py:65:9: Q000 Remove bad quotes.
src/plone/api/portal.py:66:9: Q000 Remove bad quotes.
src/plone/api/portal.py:67:9: Q000 Remove bad quotes.
src/plone/api/portal.py:113:13: Q000 Remove bad quotes.
src/plone/api/portal.py:114:13: Q000 Remove bad quotes.
src/plone/api/portal.py:264:17: Q000 Remove bad quotes.
src/plone/api/portal.py:265:17: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api@3/src/plone/api/user.py Imports are incorrectly sorted.
src/plone/api/user.py:0:1: I001 found unsorted imports
src/plone/api/user.py:66:13: Q000 Remove bad quotes.
src/plone/api/user.py:67:13: Q000 Remove bad quotes.
src/plone/api/user.py:353:37: Q000 Remove bad quotes.
src/plone/api/user.py:396:37: Q000 Remove bad quotes.
src/plone/api/validation.py:20:13: Q000 Remove bad quotes.
src/plone/api/validation.py:21:13: Q000 Remove bad quotes.
src/plone/api/validation.py:22:32: Q000 Remove bad quotes.
src/plone/api/validation.py:66:21: Q000 Remove bad quotes.
src/plone/api/validation.py:67:25: Q000 Remove bad quotes.
src/plone/api/validation.py:96:21: Q000 Remove bad quotes.
src/plone/api/validation.py:97:25: Q000 Remove bad quotes.
src/plone/api/validation.py:127:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:45: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api@3/src/plone/api/tests/base.py Imports are incorrectly sorted.
src/plone/api/tests/base.py:0:1: I001 found unsorted imports
src/plone/api/tests/base.py:32:47: Q000 Remove bad quotes.
src/plone/api/tests/base.py:60:28: Q000 Remove bad quotes.
src/plone/api/tests/base.py:62:28: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api@3/src/plone/api/tests/test_content.py Imports are incorrectly sorted.
src/plone/api/tests/test_content.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_content.py:132:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:281:37: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:768:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:769:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:770:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:904:17: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:913:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:914:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:915:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:916:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:917:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:918:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:919:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:920:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:921:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:922:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:923:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:924:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:925:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:926:13: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api@3/src/plone/api/tests/test_doctests.py Imports are incorrectly sorted.
src/plone/api/tests/test_doctests.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_doctests.py:120:13: T001 print statement found.
ERROR: /home/jenkins/workspace/package-plone.api@3/src/plone/api/tests/test_env.py Imports are incorrectly sorted.
src/plone/api/tests/test_env.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_env.py:30:14: D001 found declarePublic replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:31:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
ERROR: /home/jenkins/workspace/package-plone.api@3/src/plone/api/tests/test_group.py Imports are incorrectly sorted.
src/plone/api/tests/test_group.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.api@3/src/plone/api/tests/test_portal.py Imports are incorrectly sorted.
src/plone/api/tests/test_portal.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_portal.py:41:16: P002 found "hasattr", consider replacing it
src/plone/api/tests/test_portal.py:105:41: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:105:57: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:143:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:144:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:174:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:184:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:193:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:194:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:195:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:209:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:210:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:231:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:232:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:233:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:252:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:253:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:259:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:269:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:270:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:279:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:291:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:292:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:316:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:317:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:318:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:325:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:326:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:327:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:504:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:515:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:524:44: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api@3/src/plone/api/tests/test_user.py Imports are incorrectly sorted.
src/plone/api/tests/test_user.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_user.py:636:20: Q000 Remove bad quotes.
src/plone/api/tests/test_validation.py:37:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:40:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:65:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:70:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:74:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:79:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:84:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:91:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:98:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:123:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:124:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:131:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:132:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:133:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:159:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:160:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:165:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:166:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:167:14: D001 found assertEquals replace it with assertEqual

You can run that yourself using buildout.coredev experimental/qa.cfg config file.

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaroel Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.api/11/violations

src/plone/api/content.py:5:1: I001 isort found an import in the wrong position
src/plone/api/content.py:23:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/content.py:78:28: S001 found module formatter
src/plone/api/content.py:97:13: Q000 Remove bad quotes.
src/plone/api/content.py:98:13: Q000 Remove bad quotes.
src/plone/api/content.py:99:13: Q000 Remove bad quotes.
src/plone/api/content.py:310:1: C901 '_wf_transitions_for' is too complex (12)
src/plone/api/content.py:402:17: Q000 Remove bad quotes.
src/plone/api/content.py:403:17: Q000 Remove bad quotes.
src/plone/api/content.py:430:17: Q000 Remove bad quotes.
src/plone/api/content.py:469:13: Q000 Remove bad quotes.
src/plone/api/content.py:470:13: Q000 Remove bad quotes.
src/plone/api/portal.py:5:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:6:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:7:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:9:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:23:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/portal.py:65:9: Q000 Remove bad quotes.
src/plone/api/portal.py:66:9: Q000 Remove bad quotes.
src/plone/api/portal.py:67:9: Q000 Remove bad quotes.
src/plone/api/portal.py:113:13: Q000 Remove bad quotes.
src/plone/api/portal.py:114:13: Q000 Remove bad quotes.
src/plone/api/portal.py:254:37: Q000 Remove bad quotes.
src/plone/api/portal.py:264:17: Q000 Remove bad quotes.
src/plone/api/portal.py:265:17: Q000 Remove bad quotes.
src/plone/api/env.py:18:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/user.py:5:1: I001 isort found an import in the wrong position
src/plone/api/user.py:66:13: Q000 Remove bad quotes.
src/plone/api/user.py:67:13: Q000 Remove bad quotes.
src/plone/api/user.py:353:37: Q000 Remove bad quotes.
src/plone/api/user.py:396:37: Q000 Remove bad quotes.
src/plone/api/validation.py:20:13: Q000 Remove bad quotes.
src/plone/api/validation.py:21:13: Q000 Remove bad quotes.
src/plone/api/validation.py:22:32: Q000 Remove bad quotes.
src/plone/api/validation.py:66:21: Q000 Remove bad quotes.
src/plone/api/validation.py:67:25: Q000 Remove bad quotes.
src/plone/api/validation.py:96:21: Q000 Remove bad quotes.
src/plone/api/validation.py:97:25: Q000 Remove bad quotes.
src/plone/api/validation.py:127:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:45: Q000 Remove bad quotes.
src/plone/api/tests/test_validation.py:37:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:40:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:65:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:70:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:74:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:79:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:84:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:91:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:98:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:123:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:124:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:131:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:132:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:133:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:159:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:160:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:165:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:166:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:167:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/base.py:4:1: I001 isort found an import in the wrong position
src/plone/api/tests/base.py:11:1: I001 isort found an import in the wrong position
src/plone/api/tests/base.py:12:1: I001 isort found an import in the wrong position
src/plone/api/tests/base.py:13:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/base.py:32:47: Q000 Remove bad quotes.
src/plone/api/tests/base.py:60:28: Q000 Remove bad quotes.
src/plone/api/tests/base.py:62:28: Q000 Remove bad quotes.
src/plone/api/tests/test_user.py:9:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_user.py:636:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:5:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal.py:6:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal.py:7:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal.py:25:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_portal.py:41:16: P002 found "hasattr", consider replacing it
src/plone/api/tests/test_portal.py:105:41: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:105:57: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:143:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:144:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:174:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:184:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:193:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:194:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:195:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:196:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:209:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:210:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:211:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:231:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:232:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:233:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:234:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:252:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:253:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:254:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:259:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:269:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:270:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:271:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:279:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:291:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:292:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:293:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:316:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:317:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:318:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:319:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:325:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:326:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:327:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:328:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:467:34: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:504:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:515:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:524:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:575:23: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:9:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:10:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:11:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:21:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:22:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:23:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:28:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_content.py:132:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:281:37: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:768:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:769:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:770:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:904:17: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:913:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:914:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:915:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:916:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:917:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:918:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:919:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:920:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:921:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:922:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:923:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:924:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:925:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:926:13: Q000 Remove bad quotes.
src/plone/api/tests/test_group.py:4:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_env.py:9:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_env.py:30:14: D001 found declarePublic( replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:31:14: D001 found declareProtected( replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected( replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected( replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declarePrivate( replace it with AccessControl.ClassSecurityInfo.private
src/plone/api/tests/test_doctests.py:4:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_doctests.py:7:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_doctests.py:23:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_doctests.py:120:13: T001 print statement found.

Follow these instructions to reproduce it locally.

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaroel Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.api/7/violations

src/plone/api/content.py:5:1: I001 isort found an import in the wrong position
src/plone/api/content.py:23:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/content.py:78:28: S001 found module formatter
src/plone/api/content.py:97:13: Q000 Remove bad quotes.
src/plone/api/content.py:98:13: Q000 Remove bad quotes.
src/plone/api/content.py:99:13: Q000 Remove bad quotes.
src/plone/api/content.py:310:1: C901 '_wf_transitions_for' is too complex (12)
src/plone/api/content.py:402:17: Q000 Remove bad quotes.
src/plone/api/content.py:403:17: Q000 Remove bad quotes.
src/plone/api/content.py:430:17: Q000 Remove bad quotes.
src/plone/api/content.py:469:13: Q000 Remove bad quotes.
src/plone/api/content.py:470:13: Q000 Remove bad quotes.
src/plone/api/portal.py:5:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:6:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:7:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:9:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:23:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/portal.py:65:9: Q000 Remove bad quotes.
src/plone/api/portal.py:66:9: Q000 Remove bad quotes.
src/plone/api/portal.py:67:9: Q000 Remove bad quotes.
src/plone/api/portal.py:113:13: Q000 Remove bad quotes.
src/plone/api/portal.py:114:13: Q000 Remove bad quotes.
src/plone/api/portal.py:254:37: Q000 Remove bad quotes.
src/plone/api/portal.py:264:17: Q000 Remove bad quotes.
src/plone/api/portal.py:265:17: Q000 Remove bad quotes.
src/plone/api/env.py:18:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/user.py:5:1: I001 isort found an import in the wrong position
src/plone/api/user.py:66:13: Q000 Remove bad quotes.
src/plone/api/user.py:67:13: Q000 Remove bad quotes.
src/plone/api/user.py:353:37: Q000 Remove bad quotes.
src/plone/api/user.py:396:37: Q000 Remove bad quotes.
src/plone/api/validation.py:20:13: Q000 Remove bad quotes.
src/plone/api/validation.py:21:13: Q000 Remove bad quotes.
src/plone/api/validation.py:22:32: Q000 Remove bad quotes.
src/plone/api/validation.py:66:21: Q000 Remove bad quotes.
src/plone/api/validation.py:67:25: Q000 Remove bad quotes.
src/plone/api/validation.py:96:21: Q000 Remove bad quotes.
src/plone/api/validation.py:97:25: Q000 Remove bad quotes.
src/plone/api/validation.py:127:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:45: Q000 Remove bad quotes.
src/plone/api/tests/test_validation.py:37:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:40:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:65:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:70:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:74:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:79:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:84:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:91:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:98:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:123:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:124:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:131:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:132:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:133:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:159:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:160:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:165:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:166:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:167:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/base.py:4:1: I001 isort found an import in the wrong position
src/plone/api/tests/base.py:11:1: I001 isort found an import in the wrong position
src/plone/api/tests/base.py:12:1: I001 isort found an import in the wrong position
src/plone/api/tests/base.py:13:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/base.py:32:47: Q000 Remove bad quotes.
src/plone/api/tests/base.py:60:28: Q000 Remove bad quotes.
src/plone/api/tests/base.py:62:28: Q000 Remove bad quotes.
src/plone/api/tests/test_user.py:9:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_user.py:636:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:5:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal.py:6:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal.py:7:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal.py:25:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_portal.py:41:16: P002 found "hasattr", consider replacing it
src/plone/api/tests/test_portal.py:105:41: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:105:57: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:143:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:144:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:174:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:184:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:193:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:194:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:195:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:196:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:209:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:210:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:211:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:231:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:232:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:233:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:234:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:252:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:253:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:254:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:259:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:269:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:270:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:271:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:279:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:291:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:292:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:293:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:316:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:317:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:318:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:319:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:325:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:326:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:327:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:328:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:467:34: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:504:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:515:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:524:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:575:23: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:9:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:10:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:11:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:21:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:22:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:23:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:28:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_content.py:132:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:281:37: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:768:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:769:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:770:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:904:17: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:913:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:914:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:915:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:916:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:917:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:918:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:919:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:920:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:921:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:922:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:923:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:924:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:925:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:926:13: Q000 Remove bad quotes.
src/plone/api/tests/test_group.py:4:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_env.py:9:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_env.py:30:14: D001 found declarePublic( replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:31:14: D001 found declareProtected( replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected( replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected( replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declarePrivate( replace it with AccessControl.ClassSecurityInfo.private
src/plone/api/tests/test_doctests.py:4:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_doctests.py:7:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_doctests.py:23:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_doctests.py:120:13: T001 print statement found.

Follow these instructions to reproduce it locally.

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaroel Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.api/156/violations

src/plone/api/content.py:5:1: I001 isort found an import in the wrong position
src/plone/api/content.py:23:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/content.py:43:13: C816 missing trailing comma in Python 3.6+
src/plone/api/content.py:78:28: S001 found module formatter
src/plone/api/content.py:97:13: Q000 Remove bad quotes.
src/plone/api/content.py:98:13: Q000 Remove bad quotes.
src/plone/api/content.py:99:13: Q000 Remove bad quotes.
src/plone/api/content.py:99:68: C812 missing trailing comma
src/plone/api/content.py:257:55: C812 missing trailing comma
src/plone/api/content.py:310:1: C901 '_wf_transitions_for' is too complex (12)
src/plone/api/content.py:402:17: Q000 Remove bad quotes.
src/plone/api/content.py:403:17: Q000 Remove bad quotes.
src/plone/api/content.py:403:73: C812 missing trailing comma
src/plone/api/content.py:430:17: Q000 Remove bad quotes.
src/plone/api/content.py:433:18: C812 missing trailing comma
src/plone/api/content.py:469:13: Q000 Remove bad quotes.
src/plone/api/content.py:470:13: Q000 Remove bad quotes.
src/plone/api/content.py:470:72: C812 missing trailing comma
src/plone/api/portal.py:5:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:6:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:7:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:9:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:23:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/portal.py:32:51: C812 missing trailing comma
src/plone/api/portal.py:65:9: Q000 Remove bad quotes.
src/plone/api/portal.py:66:9: Q000 Remove bad quotes.
src/plone/api/portal.py:67:9: Q000 Remove bad quotes.
src/plone/api/portal.py:67:46: C812 missing trailing comma
src/plone/api/portal.py:113:13: Q000 Remove bad quotes.
src/plone/api/portal.py:114:13: Q000 Remove bad quotes.
src/plone/api/portal.py:114:49: C812 missing trailing comma
src/plone/api/portal.py:174:23: C812 missing trailing comma
src/plone/api/portal.py:233:20: T000 Todo note found.
src/plone/api/portal.py:254:37: Q000 Remove bad quotes.
src/plone/api/portal.py:264:17: Q000 Remove bad quotes.
src/plone/api/portal.py:265:17: Q000 Remove bad quotes.
src/plone/api/portal.py:265:55: C812 missing trailing comma
src/plone/api/portal.py:269:68: C812 missing trailing comma
src/plone/api/env.py:18:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/user.py:5:1: I001 isort found an import in the wrong position
src/plone/api/user.py:26:20: C812 missing trailing comma
src/plone/api/user.py:66:13: Q000 Remove bad quotes.
src/plone/api/user.py:67:13: Q000 Remove bad quotes.
src/plone/api/user.py:67:64: C812 missing trailing comma
src/plone/api/user.py:85:30: C812 missing trailing comma
src/plone/api/user.py:122:31: C812 missing trailing comma
src/plone/api/user.py:284:67: C812 missing trailing comma
src/plone/api/user.py:353:37: Q000 Remove bad quotes.
src/plone/api/user.py:396:37: Q000 Remove bad quotes.
src/plone/api/validation.py:20:13: Q000 Remove bad quotes.
src/plone/api/validation.py:21:13: Q000 Remove bad quotes.
src/plone/api/validation.py:22:32: Q000 Remove bad quotes.
src/plone/api/validation.py:22:54: C812 missing trailing comma
src/plone/api/validation.py:66:21: Q000 Remove bad quotes.
src/plone/api/validation.py:67:25: Q000 Remove bad quotes.
src/plone/api/validation.py:67:44: C812 missing trailing comma
src/plone/api/validation.py:96:21: Q000 Remove bad quotes.
src/plone/api/validation.py:97:25: Q000 Remove bad quotes.
src/plone/api/validation.py:97:50: C812 missing trailing comma
src/plone/api/validation.py:127:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:45: Q000 Remove bad quotes.
src/plone/api/validation.py:128:73: C812 missing trailing comma
src/plone/api/group.py:19:14: C812 missing trailing comma
src/plone/api/group.py:43:32: C812 missing trailing comma
src/plone/api/tests/test_validation.py:37:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:40:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:54:25: C812 missing trailing comma
src/plone/api/tests/test_validation.py:65:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:70:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:74:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:79:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:84:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:91:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:98:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:123:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:124:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:131:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:132:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:133:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:159:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:160:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:165:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:166:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:167:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/base.py:4:1: I001 isort found an import in the wrong position
src/plone/api/tests/base.py:11:1: I001 isort found an import in the wrong position
src/plone/api/tests/base.py:12:1: I001 isort found an import in the wrong position
src/plone/api/tests/base.py:13:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/base.py:32:47: Q000 Remove bad quotes.
src/plone/api/tests/base.py:60:28: Q000 Remove bad quotes.
src/plone/api/tests/base.py:62:28: Q000 Remove bad quotes.
src/plone/api/tests/test_user.py:9:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_user.py:68:53: C812 missing trailing comma
src/plone/api/tests/test_user.py:82:30: C812 missing trailing comma
src/plone/api/tests/test_user.py:130:42: C812 missing trailing comma
src/plone/api/tests/test_user.py:139:41: C812 missing trailing comma
src/plone/api/tests/test_user.py:143:52: C812 missing trailing comma
src/plone/api/tests/test_user.py:152:21: C812 missing trailing comma
src/plone/api/tests/test_user.py:156:32: C812 missing trailing comma
src/plone/api/tests/test_user.py:240:33: C812 missing trailing comma
src/plone/api/tests/test_user.py:274:24: C812 missing trailing comma
src/plone/api/tests/test_user.py:286:24: C812 missing trailing comma
src/plone/api/tests/test_user.py:298:24: C812 missing trailing comma
src/plone/api/tests/test_user.py:305:26: C812 missing trailing comma
src/plone/api/tests/test_user.py:315:30: T000 Todo note found.
src/plone/api/tests/test_user.py:317:51: C812 missing trailing comma
src/plone/api/tests/test_user.py:385:21: C812 missing trailing comma
src/plone/api/tests/test_user.py:392:26: C812 missing trailing comma
src/plone/api/tests/test_user.py:405:72: C812 missing trailing comma
src/plone/api/tests/test_user.py:409:65: C812 missing trailing comma
src/plone/api/tests/test_user.py:490:24: C812 missing trailing comma
src/plone/api/tests/test_user.py:495:24: C812 missing trailing comma
src/plone/api/tests/test_user.py:636:20: Q000 Remove bad quotes.
src/plone/api/tests/test_user.py:643:63: C812 missing trailing comma
src/plone/api/tests/test_portal.py:4:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal.py:5:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal.py:6:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal.py:7:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal.py:25:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_portal.py:41:16: P002 found "hasattr", consider replacing it
src/plone/api/tests/test_portal.py:51:57: C812 missing trailing comma
src/plone/api/tests/test_portal.py:55:37: C812 missing trailing comma
src/plone/api/tests/test_portal.py:60:59: C812 missing trailing comma
src/plone/api/tests/test_portal.py:105:41: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:105:57: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:143:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:144:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:174:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:184:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:193:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:194:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:195:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:196:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:209:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:210:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:211:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:231:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:232:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:233:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:234:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:252:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:253:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:254:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:259:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:259:59: C812 missing trailing comma
src/plone/api/tests/test_portal.py:269:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:270:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:271:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:279:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:279:54: C812 missing trailing comma
src/plone/api/tests/test_portal.py:291:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:292:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:293:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:316:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:317:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:318:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:319:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:319:41: C812 missing trailing comma
src/plone/api/tests/test_portal.py:325:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:326:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:327:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:328:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:467:34: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:504:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:515:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:524:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:575:23: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:9:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:10:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:11:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:21:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:22:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:23:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:28:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_content.py:107:53: C812 missing trailing comma
src/plone/api/tests/test_content.py:126:30: C812 missing trailing comma
src/plone/api/tests/test_content.py:132:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:133:33: C812 missing trailing comma
src/plone/api/tests/test_content.py:157:30: C812 missing trailing comma
src/plone/api/tests/test_content.py:185:38: C812 missing trailing comma
src/plone/api/tests/test_content.py:266:77: C812 missing trailing comma
src/plone/api/tests/test_content.py:275:65: C812 missing trailing comma
src/plone/api/tests/test_content.py:281:37: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:314:28: C812 missing trailing comma
src/plone/api/tests/test_content.py:450:35: C812 missing trailing comma
src/plone/api/tests/test_content.py:496:25: C812 missing trailing comma
src/plone/api/tests/test_content.py:695:48: C812 missing trailing comma
src/plone/api/tests/test_content.py:702:48: C812 missing trailing comma
src/plone/api/tests/test_content.py:768:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:769:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:770:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:770:22: C812 missing trailing comma
src/plone/api/tests/test_content.py:777:34: C812 missing trailing comma
src/plone/api/tests/test_content.py:897:32: C812 missing trailing comma
src/plone/api/tests/test_content.py:904:17: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:905:21: C812 missing trailing comma
src/plone/api/tests/test_content.py:906:14: C812 missing trailing comma
src/plone/api/tests/test_content.py:913:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:914:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:915:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:916:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:917:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:918:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:919:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:920:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:921:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:922:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:923:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:924:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:925:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:926:13: Q000 Remove bad quotes.
src/plone/api/tests/test_group.py:4:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_group.py:195:33: C812 missing trailing comma
src/plone/api/tests/test_env.py:9:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_env.py:30:14: D001 found declarePublic( replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:31:14: D001 found declareProtected( replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected( replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected( replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declarePrivate( replace it with AccessControl.ClassSecurityInfo.private
src/plone/api/tests/test_env.py:408:59: C812 missing trailing comma
src/plone/api/tests/test_env.py:419:59: C812 missing trailing comma
src/plone/api/tests/test_doctests.py:4:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_doctests.py:7:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_doctests.py:23:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_doctests.py:78:72: C812 missing trailing comma
src/plone/api/tests/test_doctests.py:104:36: C812 missing trailing comma
src/plone/api/tests/test_doctests.py:120:13: T001 print statement found.

Follow these instructions to reproduce it locally.

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaroel Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.api/8/violations

src/plone/api/content.py:5:1: I001 isort found an import in the wrong position
src/plone/api/content.py:23:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/content.py:43:13: C816 missing trailing comma in Python 3.6+
src/plone/api/content.py:78:28: S001 found module formatter
src/plone/api/content.py:97:13: Q000 Remove bad quotes.
src/plone/api/content.py:98:13: Q000 Remove bad quotes.
src/plone/api/content.py:99:13: Q000 Remove bad quotes.
src/plone/api/content.py:99:68: C812 missing trailing comma
src/plone/api/content.py:257:55: C812 missing trailing comma
src/plone/api/content.py:310:1: C901 '_wf_transitions_for' is too complex (12)
src/plone/api/content.py:402:17: Q000 Remove bad quotes.
src/plone/api/content.py:403:17: Q000 Remove bad quotes.
src/plone/api/content.py:403:73: C812 missing trailing comma
src/plone/api/content.py:430:17: Q000 Remove bad quotes.
src/plone/api/content.py:433:18: C812 missing trailing comma
src/plone/api/content.py:469:13: Q000 Remove bad quotes.
src/plone/api/content.py:470:13: Q000 Remove bad quotes.
src/plone/api/content.py:470:72: C812 missing trailing comma
src/plone/api/portal.py:5:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:6:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:7:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:9:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:23:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/portal.py:32:51: C812 missing trailing comma
src/plone/api/portal.py:65:9: Q000 Remove bad quotes.
src/plone/api/portal.py:66:9: Q000 Remove bad quotes.
src/plone/api/portal.py:67:9: Q000 Remove bad quotes.
src/plone/api/portal.py:67:46: C812 missing trailing comma
src/plone/api/portal.py:113:13: Q000 Remove bad quotes.
src/plone/api/portal.py:114:13: Q000 Remove bad quotes.
src/plone/api/portal.py:114:49: C812 missing trailing comma
src/plone/api/portal.py:174:23: C812 missing trailing comma
src/plone/api/portal.py:233:20: T000 Todo note found.
src/plone/api/portal.py:254:37: Q000 Remove bad quotes.
src/plone/api/portal.py:264:17: Q000 Remove bad quotes.
src/plone/api/portal.py:265:17: Q000 Remove bad quotes.
src/plone/api/portal.py:265:55: C812 missing trailing comma
src/plone/api/portal.py:269:68: C812 missing trailing comma
src/plone/api/env.py:18:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/user.py:5:1: I001 isort found an import in the wrong position
src/plone/api/user.py:26:20: C812 missing trailing comma
src/plone/api/user.py:66:13: Q000 Remove bad quotes.
src/plone/api/user.py:67:13: Q000 Remove bad quotes.
src/plone/api/user.py:67:64: C812 missing trailing comma
src/plone/api/user.py:85:30: C812 missing trailing comma
src/plone/api/user.py:122:31: C812 missing trailing comma
src/plone/api/user.py:284:67: C812 missing trailing comma
src/plone/api/user.py:353:37: Q000 Remove bad quotes.
src/plone/api/user.py:396:37: Q000 Remove bad quotes.
src/plone/api/validation.py:20:13: Q000 Remove bad quotes.
src/plone/api/validation.py:21:13: Q000 Remove bad quotes.
src/plone/api/validation.py:22:32: Q000 Remove bad quotes.
src/plone/api/validation.py:22:54: C812 missing trailing comma
src/plone/api/validation.py:66:21: Q000 Remove bad quotes.
src/plone/api/validation.py:67:25: Q000 Remove bad quotes.
src/plone/api/validation.py:67:44: C812 missing trailing comma
src/plone/api/validation.py:96:21: Q000 Remove bad quotes.
src/plone/api/validation.py:97:25: Q000 Remove bad quotes.
src/plone/api/validation.py:97:50: C812 missing trailing comma
src/plone/api/validation.py:127:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:45: Q000 Remove bad quotes.
src/plone/api/validation.py:128:73: C812 missing trailing comma
src/plone/api/group.py:19:14: C812 missing trailing comma
src/plone/api/group.py:43:32: C812 missing trailing comma
src/plone/api/tests/test_validation.py:37:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:40:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:54:25: C812 missing trailing comma
src/plone/api/tests/test_validation.py:65:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:70:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:74:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:79:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:84:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:91:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:98:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:123:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:124:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:131:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:132:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:133:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:159:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:160:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:165:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:166:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:167:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/base.py:4:1: I001 isort found an import in the wrong position
src/plone/api/tests/base.py:11:1: I001 isort found an import in the wrong position
src/plone/api/tests/base.py:12:1: I001 isort found an import in the wrong position
src/plone/api/tests/base.py:13:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/base.py:32:47: Q000 Remove bad quotes.
src/plone/api/tests/base.py:60:28: Q000 Remove bad quotes.
src/plone/api/tests/base.py:62:28: Q000 Remove bad quotes.
src/plone/api/tests/test_user.py:9:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_user.py:68:53: C812 missing trailing comma
src/plone/api/tests/test_user.py:82:30: C812 missing trailing comma
src/plone/api/tests/test_user.py:130:42: C812 missing trailing comma
src/plone/api/tests/test_user.py:139:41: C812 missing trailing comma
src/plone/api/tests/test_user.py:143:52: C812 missing trailing comma
src/plone/api/tests/test_user.py:152:21: C812 missing trailing comma
src/plone/api/tests/test_user.py:156:32: C812 missing trailing comma
src/plone/api/tests/test_user.py:240:33: C812 missing trailing comma
src/plone/api/tests/test_user.py:274:24: C812 missing trailing comma
src/plone/api/tests/test_user.py:286:24: C812 missing trailing comma
src/plone/api/tests/test_user.py:298:24: C812 missing trailing comma
src/plone/api/tests/test_user.py:305:26: C812 missing trailing comma
src/plone/api/tests/test_user.py:315:30: T000 Todo note found.
src/plone/api/tests/test_user.py:317:51: C812 missing trailing comma
src/plone/api/tests/test_user.py:385:21: C812 missing trailing comma
src/plone/api/tests/test_user.py:392:26: C812 missing trailing comma
src/plone/api/tests/test_user.py:405:72: C812 missing trailing comma
src/plone/api/tests/test_user.py:409:65: C812 missing trailing comma
src/plone/api/tests/test_user.py:490:24: C812 missing trailing comma
src/plone/api/tests/test_user.py:495:24: C812 missing trailing comma
src/plone/api/tests/test_user.py:636:20: Q000 Remove bad quotes.
src/plone/api/tests/test_user.py:643:63: C812 missing trailing comma
src/plone/api/tests/test_portal.py:4:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal.py:5:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal.py:6:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal.py:7:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal.py:25:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_portal.py:41:16: P002 found "hasattr", consider replacing it
src/plone/api/tests/test_portal.py:51:57: C812 missing trailing comma
src/plone/api/tests/test_portal.py:55:37: C812 missing trailing comma
src/plone/api/tests/test_portal.py:60:59: C812 missing trailing comma
src/plone/api/tests/test_portal.py:105:41: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:105:57: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:143:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:144:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:174:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:184:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:193:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:194:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:195:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:196:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:209:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:210:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:211:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:231:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:232:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:233:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:234:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:252:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:253:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:254:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:259:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:259:59: C812 missing trailing comma
src/plone/api/tests/test_portal.py:269:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:270:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:271:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:279:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:279:54: C812 missing trailing comma
src/plone/api/tests/test_portal.py:291:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:292:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:293:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:316:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:317:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:318:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:319:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:319:41: C812 missing trailing comma
src/plone/api/tests/test_portal.py:325:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:326:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:327:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:328:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:467:34: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:504:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:515:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:524:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:575:23: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:9:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:10:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:11:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:21:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:22:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:23:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:28:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_content.py:107:53: C812 missing trailing comma
src/plone/api/tests/test_content.py:126:30: C812 missing trailing comma
src/plone/api/tests/test_content.py:132:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:133:33: C812 missing trailing comma
src/plone/api/tests/test_content.py:157:30: C812 missing trailing comma
src/plone/api/tests/test_content.py:185:38: C812 missing trailing comma
src/plone/api/tests/test_content.py:266:77: C812 missing trailing comma
src/plone/api/tests/test_content.py:275:65: C812 missing trailing comma
src/plone/api/tests/test_content.py:281:37: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:314:28: C812 missing trailing comma
src/plone/api/tests/test_content.py:450:35: C812 missing trailing comma
src/plone/api/tests/test_content.py:496:25: C812 missing trailing comma
src/plone/api/tests/test_content.py:695:48: C812 missing trailing comma
src/plone/api/tests/test_content.py:702:48: C812 missing trailing comma
src/plone/api/tests/test_content.py:768:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:769:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:770:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:770:22: C812 missing trailing comma
src/plone/api/tests/test_content.py:777:34: C812 missing trailing comma
src/plone/api/tests/test_content.py:897:32: C812 missing trailing comma
src/plone/api/tests/test_content.py:904:17: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:905:21: C812 missing trailing comma
src/plone/api/tests/test_content.py:906:14: C812 missing trailing comma
src/plone/api/tests/test_content.py:913:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:914:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:915:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:916:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:917:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:918:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:919:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:920:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:921:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:922:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:923:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:924:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:925:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:926:13: Q000 Remove bad quotes.
src/plone/api/tests/test_group.py:4:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_group.py:195:33: C812 missing trailing comma
src/plone/api/tests/test_env.py:9:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_env.py:30:14: D001 found declarePublic( replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:31:14: D001 found declareProtected( replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected( replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected( replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declarePrivate( replace it with AccessControl.ClassSecurityInfo.private
src/plone/api/tests/test_env.py:408:59: C812 missing trailing comma
src/plone/api/tests/test_env.py:419:59: C812 missing trailing comma
src/plone/api/tests/test_doctests.py:4:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_doctests.py:7:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_doctests.py:23:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_doctests.py:78:72: C812 missing trailing comma
src/plone/api/tests/test_doctests.py:104:36: C812 missing trailing comma
src/plone/api/tests/test_doctests.py:120:13: T001 print statement found.

Follow these instructions to reproduce it locally.

Please sign in to comment.