Skip to content

Commit

Permalink
Add Plone 5 only tests to make sure the new registry lookups work.
Browse files Browse the repository at this point in the history
  • Loading branch information
tisto committed Sep 16, 2015
1 parent 2b3623f commit b7aadcc
Showing 1 changed file with 328 additions and 0 deletions.
328 changes: 328 additions & 0 deletions src/plone/api/tests/test_portal_get_registry.py
@@ -0,0 +1,328 @@
# -*- coding: utf-8 -*-
from plone.api.tests.base import INTEGRATION_TESTING
from plone import api
import unittest


class TestPloneSettings(unittest.TestCase):
"""Test that all plone.app.registry-based settings in CMFPlone can be
looked up with get_registry_record.
"""
layer = INTEGRATION_TESTING

def setUp(self):
self.portal = self.layer['portal']

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_editing_settings(self):
keys = [
'plone.available_editors',
'plone.default_editor',
'plone.ext_editor',
'plone.enable_link_integrity_checks',
'plone.lock_on_ttw_edit',
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_language_settings(self):
keys = [
'plone.default_language',
'plone.available_languages',
'plone.use_combined_language_codes',
'plone.display_flags',
'plone.always_show_selector',
'plone.use_content_negotiation',
'plone.use_path_negotiation',
'plone.use_cookie_negotiation',
'plone.authenticated_users_only',
'plone.set_cookie_always',
'plone.use_subdomain_negotiation',
'plone.use_cctld_negotiation',
'plone.use_request_negotiation',
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_filter_settings(self):
keys = [
'plone.disable_filtering',
'plone.nasty_tags',
'plone.stripped_tags',
'plone.custom_tags',
'plone.stripped_attributes',
'plone.stripped_combinations',
'plone.style_whitelist',
'plone.class_blacklist',
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_tinymce_settings(self):
keys = [
'plone.resizing',
'plone.autoresize',
'plone.editor_width',
'plone.editor_height',
'plone.content_css',
'plone.header_styles',
'plone.inline_styles',
'plone.block_styles',
'plone.alignment_styles',
'plone.formats',
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_tinymce_resource_types_settings(self):
keys = [
'plone.plugins',
'plone.menubar',
'plone.menu',
'plone.templates',
'plone.toolbar',
'plone.custom_plugins',
'plone.custom_buttons',
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_tinymce_spellchecker_settings(self):
keys = [
'plone.libraries_spellchecker_choice',
'plone.libraries_atd_ignore_strings',
'plone.libraries_atd_show_types',
'plone.libraries_atd_service_url',
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_maintenance_settings(self):
keys = [
'plone.days',
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_navigation_settings(self):
keys = [
'plone.generate_tabs',
'plone.nonfolderish_tabs',
'plone.displayed_types',
'plone.filter_on_workflow',
'plone.workflow_states_to_show',
'plone.show_excluded_items',
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_search_settings(self):
keys = [
'plone.enable_livesearch',
'plone.types_not_searched',
'plone.search_results_description_length',
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_security_settings(self):
keys = [
'plone.enable_self_reg',
'plone.enable_user_pwd_choice',
'plone.enable_user_folders',
'plone.allow_anon_views_about',
'plone.use_email_as_login',
'plone.use_uuid_as_userid',
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_site_settings(self):
keys = [
'plone.site_title',
'plone.site_logo',
'plone.exposeDCMetaTags',
'plone.enable_sitemap',
'plone.webstats_js',
'plone.display_publication_date_in_byline',
'plone.icon_visibility',
'plone.toolbar_position',
'plone.toolbar_logo',
'plone.robots_txt',
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_date_and_time_settings(self):
keys = [
'plone.portal_timezone',
'plone.available_timezones',
'plone.first_weekday',
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_mail_settings(self):
keys = [
'plone.smtp_host',
'plone.smtp_port',
'plone.smtp_userid',
'plone.smtp_pass',
'plone.email_from_name',
'plone.email_from_address',
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_markup_settings(self):
keys = [
'plone.default_type',
'plone.allowed_types'
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_users_and_groups_settings(self):
keys = [
'plone.many_groups',
'plone.many_users'
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_social_media_settings(self):
keys = [
'plone.share_social_data',
'plone.twitter_username',
'plone.facebook_app_id',
'plone.facebook_username',
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_imaging_settings(self):
keys = [
'plone.allowed_sizes',
'plone.quality',
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

@unittest.skipIf(api.env.plone_version() <= '5.0b2', 'Plone 5 only')
def test_login_settings(self):
keys = [
'plone.auth_cookie_length',
'plone.verify_login_name',
'plone.allow_external_login_sites',
'plone.external_login_url',
'plone.external_logout_url',
'plone.external_login_iframe',
]
for key in keys:
raised = False
try:
api.portal.get_registry_record(key),
except:
raised = True
self.assertFalse(raised, "'{}' not found in registry.".format(key))

2 comments on commit b7aadcc

@gforcada
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisto Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.api/16//violations

ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/content.py Imports are incorrectly sorted.
src/plone/api/content.py:0:1: I001 found unsorted imports
src/plone/api/content.py:98:13: Q000 Remove bad quotes.
src/plone/api/content.py:99:13: Q000 Remove bad quotes.
src/plone/api/content.py:100:13: Q000 Remove bad quotes.
src/plone/api/content.py:268:1: C901 'delete' is too complex (15)
src/plone/api/content.py:300:25: Q000 Remove bad quotes.
src/plone/api/content.py:322:25: Q000 Remove bad quotes.
src/plone/api/content.py:360:1: C901 '_wf_transitions_for' is too complex (12)
src/plone/api/content.py:454:17: Q000 Remove bad quotes.
src/plone/api/content.py:455:17: Q000 Remove bad quotes.
src/plone/api/content.py:482:17: Q000 Remove bad quotes.
src/plone/api/content.py:521:13: Q000 Remove bad quotes.
src/plone/api/content.py:522:13: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/env.py Imports are incorrectly sorted.
src/plone/api/env.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/portal.py Imports are incorrectly sorted.
src/plone/api/portal.py:0:1: I001 found unsorted imports
src/plone/api/portal.py:65:9: Q000 Remove bad quotes.
src/plone/api/portal.py:66:9: Q000 Remove bad quotes.
src/plone/api/portal.py:67:9: Q000 Remove bad quotes.
src/plone/api/portal.py:113:13: Q000 Remove bad quotes.
src/plone/api/portal.py:114:13: Q000 Remove bad quotes.
src/plone/api/portal.py:264:17: Q000 Remove bad quotes.
src/plone/api/portal.py:265:17: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/user.py Imports are incorrectly sorted.
src/plone/api/user.py:0:1: I001 found unsorted imports
src/plone/api/user.py:70:13: Q000 Remove bad quotes.
src/plone/api/user.py:71:13: Q000 Remove bad quotes.
src/plone/api/user.py:357:37: Q000 Remove bad quotes.
src/plone/api/user.py:400:37: Q000 Remove bad quotes.
src/plone/api/validation.py:20:13: Q000 Remove bad quotes.
src/plone/api/validation.py:21:13: Q000 Remove bad quotes.
src/plone/api/validation.py:22:32: Q000 Remove bad quotes.
src/plone/api/validation.py:66:21: Q000 Remove bad quotes.
src/plone/api/validation.py:67:25: Q000 Remove bad quotes.
src/plone/api/validation.py:96:21: Q000 Remove bad quotes.
src/plone/api/validation.py:97:25: Q000 Remove bad quotes.
src/plone/api/validation.py:127:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:45: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/base.py Imports are incorrectly sorted.
src/plone/api/tests/base.py:0:1: I001 found unsorted imports
src/plone/api/tests/base.py:32:47: Q000 Remove bad quotes.
src/plone/api/tests/base.py:60:28: Q000 Remove bad quotes.
src/plone/api/tests/base.py:62:28: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_content.py Imports are incorrectly sorted.
src/plone/api/tests/test_content.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_content.py:137:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:271:37: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:879:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:880:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:881:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1015:17: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1024:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1025:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1026:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1027:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1028:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1029:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1030:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1031:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1032:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1033:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1034:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1035:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1036:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1037:13: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_doctests.py Imports are incorrectly sorted.
src/plone/api/tests/test_doctests.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_doctests.py:120:13: T001 print statement found.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_env.py Imports are incorrectly sorted.
src/plone/api/tests/test_env.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_env.py:30:14: D001 found declarePublic replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:31:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_group.py Imports are incorrectly sorted.
src/plone/api/tests/test_group.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_portal.py Imports are incorrectly sorted.
src/plone/api/tests/test_portal.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_portal.py:41:16: P002 found "hasattr", consider replacing it
src/plone/api/tests/test_portal.py:105:41: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:105:57: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:143:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:144:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:174:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:184:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:193:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:194:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:195:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:209:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:210:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:231:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:232:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:233:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:252:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:253:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:259:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:269:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:270:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:279:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:291:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:292:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:316:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:317:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:318:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:325:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:326:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:327:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:504:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:515:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:524:44: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_portal_get_registry.py Imports are incorrectly sorted.
src/plone/api/tests/test_portal_get_registry.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_portal_get_registry.py:29:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:31:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:54:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:56:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:74:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:76:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:96:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:98:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:115:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:117:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:131:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:133:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:144:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:146:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:162:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:164:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:177:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:179:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:195:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:197:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:217:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:219:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:232:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:234:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:250:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:252:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:264:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:266:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:278:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:280:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:294:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:296:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:308:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:310:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:326:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:328:38: P101 format string does contain unindexed parameters
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_user.py Imports are incorrectly sorted.
src/plone/api/tests/test_user.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_user.py:641:20: Q000 Remove bad quotes.
src/plone/api/tests/test_validation.py:37:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:40:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:65:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:70:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:74:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:79:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:84:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:91:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:98:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:123:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:124:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:131:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:132:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:133:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:159:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:160:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:165:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:166:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:167:14: D001 found assertEquals replace it with assertEqual

You can run that yourself using buildout.coredev experimental/qa.cfg config file.

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisto Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.api/13/violations

src/plone/api/portal.py:5:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:6:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:7:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:9:1: I001 isort found an import in the wrong position
src/plone/api/portal.py:23:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/portal.py:65:9: Q000 Remove bad quotes.
src/plone/api/portal.py:66:9: Q000 Remove bad quotes.
src/plone/api/portal.py:67:9: Q000 Remove bad quotes.
src/plone/api/portal.py:113:13: Q000 Remove bad quotes.
src/plone/api/portal.py:114:13: Q000 Remove bad quotes.
src/plone/api/portal.py:254:37: Q000 Remove bad quotes.
src/plone/api/portal.py:264:17: Q000 Remove bad quotes.
src/plone/api/portal.py:265:17: Q000 Remove bad quotes.
src/plone/api/user.py:5:1: I001 isort found an import in the wrong position
src/plone/api/user.py:70:13: Q000 Remove bad quotes.
src/plone/api/user.py:71:13: Q000 Remove bad quotes.
src/plone/api/user.py:357:37: Q000 Remove bad quotes.
src/plone/api/user.py:400:37: Q000 Remove bad quotes.
src/plone/api/content.py:4:1: I001 isort found an import in the wrong position
src/plone/api/content.py:14:1: I001 isort found an import in the wrong position
src/plone/api/content.py:15:1: I001 isort found an import in the wrong position
src/plone/api/content.py:26:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/content.py:98:13: Q000 Remove bad quotes.
src/plone/api/content.py:99:13: Q000 Remove bad quotes.
src/plone/api/content.py:100:13: Q000 Remove bad quotes.
src/plone/api/content.py:268:1: C901 'delete' is too complex (15)
src/plone/api/content.py:300:25: Q000 Remove bad quotes.
src/plone/api/content.py:322:25: Q000 Remove bad quotes.
src/plone/api/content.py:360:1: C901 '_wf_transitions_for' is too complex (12)
src/plone/api/content.py:454:17: Q000 Remove bad quotes.
src/plone/api/content.py:455:17: Q000 Remove bad quotes.
src/plone/api/content.py:482:17: Q000 Remove bad quotes.
src/plone/api/content.py:521:13: Q000 Remove bad quotes.
src/plone/api/content.py:522:13: Q000 Remove bad quotes.
src/plone/api/validation.py:20:13: Q000 Remove bad quotes.
src/plone/api/validation.py:21:13: Q000 Remove bad quotes.
src/plone/api/validation.py:22:32: Q000 Remove bad quotes.
src/plone/api/validation.py:66:21: Q000 Remove bad quotes.
src/plone/api/validation.py:67:25: Q000 Remove bad quotes.
src/plone/api/validation.py:96:21: Q000 Remove bad quotes.
src/plone/api/validation.py:97:25: Q000 Remove bad quotes.
src/plone/api/validation.py:127:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:45: Q000 Remove bad quotes.
src/plone/api/env.py:18:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_portal_get_registry.py:3:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal_get_registry.py:4:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_portal_get_registry.py:29:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:31:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:54:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:56:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:74:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:76:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:96:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:98:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:115:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:117:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:131:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:133:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:144:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:146:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:162:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:164:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:177:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:179:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:195:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:197:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:217:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:219:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:232:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:234:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:250:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:252:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:264:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:266:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:278:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:280:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:294:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:296:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:308:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:310:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_portal_get_registry.py:326:13: B901 blind except: statement
src/plone/api/tests/test_portal_get_registry.py:328:38: P101 format string does contain unindexed parameters
src/plone/api/tests/test_content.py:8:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:9:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:10:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:14:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:15:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:28:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_content.py:33:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_content.py:137:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:271:37: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:879:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:880:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:881:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1015:17: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1024:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1025:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1026:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1027:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1028:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1029:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1030:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1031:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1032:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1033:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1034:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1035:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1036:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1037:13: Q000 Remove bad quotes.
src/plone/api/tests/test_env.py:9:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_env.py:30:14: D001 found declarePublic( replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:31:14: D001 found declareProtected( replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected( replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected( replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declarePrivate( replace it with AccessControl.ClassSecurityInfo.private
src/plone/api/tests/test_doctests.py:4:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_doctests.py:7:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_doctests.py:23:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_doctests.py:120:13: T001 print statement found.
src/plone/api/tests/test_validation.py:37:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:40:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:65:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:70:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:74:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:79:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:84:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:91:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:98:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:123:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:124:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:131:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:132:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:133:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:159:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:160:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:165:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:166:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_validation.py:167:14: D001 found assertEquals( replace it with assertEqual
src/plone/api/tests/test_portal.py:5:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal.py:6:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal.py:7:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_portal.py:25:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/test_portal.py:41:16: P002 found "hasattr", consider replacing it
src/plone/api/tests/test_portal.py:105:41: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:105:57: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:143:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:144:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:174:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:184:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:193:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:194:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:195:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:196:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:209:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:210:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:211:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:231:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:232:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:233:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:234:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:252:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:253:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:254:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:259:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:269:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:270:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:271:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:279:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:291:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:292:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:293:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:316:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:317:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:318:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:319:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:325:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:326:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:327:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:328:18: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:467:34: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:504:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:515:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:524:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:575:23: Q000 Remove bad quotes.
src/plone/api/tests/base.py:4:1: I001 isort found an import in the wrong position
src/plone/api/tests/base.py:11:1: I001 isort found an import in the wrong position
src/plone/api/tests/base.py:12:1: I001 isort found an import in the wrong position
src/plone/api/tests/base.py:13:1: I003 isort expected 1 blank line in imports, found 0
src/plone/api/tests/base.py:32:47: Q000 Remove bad quotes.
src/plone/api/tests/base.py:60:28: Q000 Remove bad quotes.
src/plone/api/tests/base.py:62:28: Q000 Remove bad quotes.
src/plone/api/tests/test_group.py:4:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_user.py:9:1: I001 isort found an import in the wrong position
src/plone/api/tests/test_user.py:641:20: Q000 Remove bad quotes.

Follow these instructions to reproduce it locally.

Please sign in to comment.