enhance readability

src/plone/api/content.py

@@ -50,7 +50,7 @@ def create(
     id=None,
     title=None,
     safe_id=False,
-    **kwargs
+    **kwargs  # NOQA: C816
 ):
     """Create a new content item.
 

src/plone/api/portal.py

@@ -260,7 +260,7 @@ def show_message(message=None, request=None, type='info'):
     :param message: [required] Message to show.
     :type message: string
     :param request: [required] Request.
-    :type request: TODO: hm?
+    :type request: HTTPRequest
     :param type: Message type. Possible values: 'info', 'warn', 'error'
     :type type: string
     :raises:
@@ -308,8 +308,8 @@ def get_registry_record(name=None, interface=None, default=MISSING):
         # Show all records on the interface.
         records = [key for key in interface.names()]
         msg = (
-            "Cannot find a record with name '{name}'"
-            " on interface {identifier}.\n"
+            'Cannot find a record with name "{name}"'
+            ' on interface {identifier}.\n'
             'Did you mean?\n'
             '{records}'.format(
                 name=name,
@@ -370,10 +370,7 @@ def set_registry_record(name=None, value=None, interface=None):
 
         from zope.schema._bootstrapinterfaces import WrongType
         try:
-            registry['{identifier}.{name}'.format(
-                identifier=interface.__identifier__,
-                name=name
-            )] = value
+            registry[interface.__identifier__ + '.' + name] = value
         except WrongType:
             field_type = [
                 field[1]

src/plone/api/tests/test_doctests.py

@@ -1,5 +1,6 @@
 # -*- coding: utf-8 -*-
 """Boilerplate for doctest functional tests."""
+
 from logging import getLogger
 from plone.app.testing import applyProfile
 from plone.app.testing import PLONE_INTEGRATION_TESTING
@@ -117,6 +118,9 @@ def test_suite():
         try:
             doctests.append(DocFileSuite(os.path.join(path, filename)))
         except IOError:
-            logger.warning('test_doctest.py skipping {0}'.format(filename))
+            logger.warning('test_doctest.py skipping {file}'.format(
+                    file=filename,
+                )
+            )
 
     return unittest.TestSuite(doctests)

src/plone/api/tests/test_env.py

@@ -143,6 +143,20 @@ def test_adopt_manager_role(self):
             ])
         self.test_test_defaults()
 
+    def test_adopt_manager_string_role(self):
+        """Test that we can adopt the Manager role temporarily."""
+        with api.env.adopt_roles(roles='Manager'):
+            self.should_allow([
+                'public_method',
+                'pp_method',
+                'qq_method',
+                'rr_method',
+            ])
+            self.should_forbid([
+                'private_method',
+            ])
+        self.test_test_defaults()
+
     def test_adopt_fewers_role(self):
         """Test that we can adopt a non-Manager role temporarily."""
         with api.env.adopt_roles(roles=['Member']):

src/plone/api/tests/test_portal.py

@@ -77,7 +77,10 @@ def setUp(self):
                 'sender@example.org',
             )
         else:
-            self.portal._updateProperty('email_from_name', 'Portal Owner')
+            self.portal._updateProperty(
+                'email_from_name',
+                'Portal Owner',
+            )
             self.portal._updateProperty(
                 'email_from_address',
                 'sender@example.org',