Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document which API calls check permissions and which don't #3

Closed
zupo opened this issue Feb 27, 2012 · 4 comments
Closed

Document which API calls check permissions and which don't #3

zupo opened this issue Feb 27, 2012 · 4 comments

Comments

@zupo
Copy link
Member

zupo commented Feb 27, 2012

We don't have this info now and we need to add it.

Also, wherever we do perform security checks, it would be nice to have flag to skip them if necessary.

If someone can go through the methods one by one and add this permissions information to docstrings, please?

@zupo
Copy link
Member Author

zupo commented Aug 20, 2012

Conclusion after discussion with Liz:

  • all plone.api code should be permission aware
  • use api.role('') context manager to bypass permissions (see roadmap)

@zupo zupo closed this as completed Aug 20, 2012
@domenkozar
Copy link
Member

I'd never guess api.role('') means bypassing permissions. Also it may happen it will happen accidently leading to security issues. I'd suggest having explicit function for this, such as api.bypass_security

@zupo
Copy link
Member Author

zupo commented Aug 20, 2012

api.role is an idea we just came up with, adding it to roadmap with a code sample just now. Name is by no means final.

@zupo
Copy link
Member Author

zupo commented Aug 20, 2012

@iElectric roadmap pushed, see if api.role() makes more sense to you when used with with: https://github.com/plone/plone.api/blob/master/src/plone/api/docs/about.rst#medium--to-long-term

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants