Change content.delete to allow obj=None and objects=[] or objects=None. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauritsvanrees
approved these changes
Sep 25, 2017
hvelarde
reviewed
Sep 25, 2017
| @@ -732,6 +732,10 @@ def test_delete_multiple(self): | |||
| self.assertNotIn('copy_of_about', container) | |||
| self.assertNotIn('about', container['events']) | |||
|
|
|||
| def test_delete_no_objs(self): | |||
| # Check that we allow passing in an empty list of objects. | |||
| api.content.delete(obj=None, objects=[]) | |||
There was a problem hiding this comment.
this test is wrong as obj and objects are mutually exclusive parameters:
@mutually_exclusive_parameters('obj', 'objects')
There was a problem hiding this comment.
The test passes, so apparently it is fine.
I see that the mutually_exclusive_parameters decorator uses _get_supplied_args, which ignores arguments that are None. That seems why it is okay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #383