Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test in Zope4 #393

Merged
merged 1 commit into from
Oct 22, 2017
Merged

Fix test in Zope4 #393

merged 1 commit into from
Oct 22, 2017

Conversation

jensens
Copy link
Sponsor Member

@jensens jensens commented Oct 22, 2017

No description provided.

davisagli
davisagli approved these changes Oct 22, 2017
View reviewed changes
Copy link
Sponsor Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but if it comes up again we might want to implement __eq__ for the MemberData adapter.

CHANGES.rst Outdated
@@ -14,6 +14,10 @@ New features:

Bug fixes:

- Fix test in Zope4, where Products.PlonePAS.tools.memberdata.MemberData is an
adapter now and cant be proofed to e equal ahen fetched twice.
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be
when

@jensens jensens merged commit 6788be5 into master Oct 22, 2017
@jensens jensens deleted the fix-test-in-zope4 branch October 22, 2017 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli approved these changes

Assignees
No one assigned
Labels
01 type: bug 23 status: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jensens @davisagli