Isort flake8 improvements #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flake8 wants it one way, isort another. And when you let isort fix it, it complains again.
The isort setups on Jenkins and Travis do not agree. Apparently it is unclear what the correct sort order is for these versions: from datetime import date from datetime import datetime as dtime So I replaced it with: import datetime as dtime We don't use simple `import datetime` under its own name, because one of the functions uses 'datetime' as an argument.
|
Hah! Now the QA job on Travis passes, but the 'real' tests fail. I guess I should have run those too. :-) Let me check. |
I thought flake8 complained about this line, but it apparently was a different one.
I wondered about this one.
When you revoke the ('Editor') roles, without comma, you revoke the role E, d, i, t, o, r.
Not what you want. :-)
('Editor',) works. A list would work too.
|
That should do it. Running Jenkins now. |
|
Okay, all green, including Travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #389.
My previous PR #396 failed on Travis for the isort and flake8 job. This should fix it.
Locally tox is happy at least. It is a Mac, which might behave slightly differently from Travis when it comes to sorting.