Fix bug in manual purging via controlpanel #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 30, 2015 11:15
…ysicalPath. The physicalPath from the request (line 562) is a list of strings. portalPath was a string, making this comparison faulty and the caching not work
|
test with this branch are running here http://jenkins.plone.org/view/All/job/pull-request/66/ |
jensens
added a commit
to plone/buildout.coredev
that referenced
this pull request
Mar 31, 2015
jensens
added a commit
that referenced
this pull request
Mar 31, 2015
Fix bug in manual purging via controlpanel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The portalPath's length is used to determine the relativePath from the physicalPath. The physicalPath from the request (line 562) is a list of strings. portalPath was joined as string and thus much longer. Resulting in empty 'relativePath', resulting in not doing all the purges you would expect.
There are no tests for the controlpanel purging, I unfortunally also do not have time to make them :(