Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move INameFromTitle interface to plone.base #271

Merged
merged 4 commits into from Nov 2, 2023

Conversation

gforcada
Copy link
Sponsor Contributor

Part of plone/Products.CMFPlone#3858

This needs plone/plone.base#51 to be merged and released.

It needs all other mentioned PRs on the tracking issue to be merged first.

It got moved to `plone.base`.

Adds a deprecation warning so the interface can be moved right away, but
does not break other code that still imports from here, and show a
deprecation warning about it.
@mister-roboto
Copy link

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@mauritsvanrees
Copy link
Sponsor Member

I have released a new plone.base version and updated the constraints at https://dist.plone.org/release/6.0-dev/ so should be fine now.
I will test this together with plone/plone.app.dexterity#379 on Jenkins.

@mauritsvanrees
Copy link
Sponsor Member

Actually, tox -e test fails on the plone.app.dexterity PR, so that needs to be fixed first. So let's test only this PR for now:

@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Sponsor Member

Unfortunately, the deferred import breaks content types that still refer to the interface in their behaviors list. Inheriting from the new interface fixes it.
This works in combination with plone/plone.app.dexterity#380.

@mauritsvanrees mauritsvanrees merged commit d487863 into master Nov 2, 2023
12 checks passed
@mauritsvanrees mauritsvanrees deleted the use-interface-from-plone-base branch November 2, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants