New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move INameFromTitle
interface to plone.base
#271
Conversation
It got moved to `plone.base`. Adds a deprecation warning so the interface can be moved right away, but does not break other code that still imports from here, and show a deprecation warning about it.
@gforcada thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
I have released a new |
Actually, @jenkins-plone-org please run jobs |
Unfortunately, the deferred import breaks content types that still refer to the interface in their behaviors list. Inheriting from the new interface fixes it. |
Part of plone/Products.CMFPlone#3858
This needs plone/plone.base#51 to be merged and released.
It needs all other mentioned PRs on the tracking issue to be merged first.