Make the dependency on plone.app.content conditional. #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for `INameFromTitle`, which we want to move to `plone.base`. See #379 (comment) for why this is not working yet, and we need this workaround.
This comment was marked as resolved.
This comment was marked as resolved.
|
@jenkins-plone-org please run jobs |
davisagli
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
@mauritsvanrees While reading your comments on #379 I had the same idea that this could be a simpler way to resolve the circular dependency -- before I saw this PR. So, I think this makes sense.
Both `plone.namefromtitle` and `plone.app.content.interfaces.INameFromTitle` work. You cannot use `plone.base.interfaces.INameFromTitle` as behavior name, this was never supported. Recommended is to use `plone.namefromtitle` in all supported Plone versions. Using `plone.app.content.interfaces.INameFromTitle` as name will stop working in Plone 7. Rewrote the `tests/namefromtitle.txt` doctest file as a unittest file, making it easier to test both behavior names.
mauritsvanrees
force-pushed
the
maurits-plone-app-content-conditional
branch
from
a08301c
to
d4ebbe1
Compare
|
I have updated the tests to test for both supported spellings of the behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for
INameFromTitle, which we want to move toplone.base. See #379 (comment) for why this is not working yet, and we need this workaround.