Use plone i18n domain #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plone.app.discussion is an official Plone core package, thus their translations belong to plone.app.locales. This commit removes the plone.app.discussion domain and changes it for plone. This fixes: #66
|
@gforcada i18ndude admix, see my comment: |
gforcada
added a commit
that referenced
this pull request
Nov 9, 2015
Translations have already been moved to plone.app.locales. See: #74 collective/plone.app.locales@b063d48
gforcada
added a commit
to plone/buildout.coredev
that referenced
this pull request
Nov 9, 2015
Branch: refs/heads/master Date: 2015-11-09T22:45:21+01:00 Author: Gil Forcada (gforcada) <gforcada@gnome.org> Commit: plone/plone.app.discussion@1823428 Remove locales folder Translations have already been moved to plone.app.locales. See: plone/plone.app.discussion#74 collective/plone.app.locales@b063d48 Files changed: D plone/app/discussion/locales/af/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/ca/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/cs/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/da/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/de/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/es/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/eu/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/fi/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/fr/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/it/LC_MESSAGES/.gitignore D plone/app/discussion/locales/it/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/ja/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/nl/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/no/LC_MESSAGES/.gitignore D plone/app/discussion/locales/no/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/plone.app.discussion-manual.pot D plone/app/discussion/locales/plone.app.discussion.pot D plone/app/discussion/locales/pt/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/pt_BR/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/ro/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/sk/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/sv/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/uk/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/zh_CN/LC_MESSAGES/plone.app.discussion.po D plone/app/discussion/locales/zh_TW/LC_MESSAGES/plone.app.discussion.po
|
@vincentfretin I followed your steps and I think I got everything right, would you mind doing a double check on it? Is there any mailing list/way to contact translators so tell them to double check the translations? |
|
@gforcada LGTM. I usually send a mail to the plone-i18n mailing-list. Maybe we should create a category in community.plone.org now. |
|
When I update an i18n domain and there is new messages to translate, I usually say it on the plone-i18n mailing-list, with some context where the new messages come from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plone.app.discussion is an official Plone core package,
thus their translations belong to plone.app.locales.
This commit removes the plone.app.discussion domain and changes it for
plone.
This fixes:
#66
@vincentfretin what would be the best way to move the translations on the locales folder over to plone.app.locales? Do you have any handy tooling for that?