Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move translations to plone.app.locales. #66

Closed
tisto opened this issue Apr 29, 2015 · 2 comments
Closed

Move translations to plone.app.locales. #66

tisto opened this issue Apr 29, 2015 · 2 comments
Assignees
@vincentfretin

Comments

@tisto
Copy link
Sponsor Member

tisto commented Apr 29, 2015

No description provided.

@vincentfretin vincentfretin mentioned this issue Apr 29, 2015
Closed
@tisto
Copy link
Sponsor Member Author

tisto commented Apr 30, 2015

@vincentfretin plone.app.discussion uses its own domain:

https://github.com/plone/plone.app.discussion/blob/master/plone/app/discussion/locales/de/LC_MESSAGES/plone.app.discussion.po#L15

How would you suggest that we proceed?

@vincentfretin
Copy link
Member

The simplest way is just to move all the content of the locales folder of plone.app.discussion master to the locales folder of plone.app.locales master I guess, and remove i18n:registerTranslations from configure.zcml.
We have plone.app.locales 4.3.x branch and master which target Plone 5.

@esteele esteele mentioned this issue Sep 15, 2015
Closed
22 tasks
gforcada added a commit that referenced this issue Nov 4, 2015
@gforcada
Use plone i18n domain
eda992f 
plone.app.discussion is an official Plone core package,
thus their translations belong to plone.app.locales.

This commit removes the plone.app.discussion domain and changes it for
plone.

This fixes:
#66
@gforcada gforcada mentioned this issue Nov 4, 2015
Merged
gforcada added a commit to plone/buildout.coredev that referenced this issue Nov 9, 2015
@gforcada
[fc] Repository: plone.app.discussion
35c32a8 
Branch: refs/heads/master
Date: 2015-11-05T00:30:42+01:00
Author: Gil Forcada (gforcada) <gforcada@gnome.org>
Commit: plone/plone.app.discussion@0713bcd

Use plone i18n domain

plone.app.discussion is an official Plone core package,
thus their translations belong to plone.app.locales.

This commit removes the plone.app.discussion domain and changes it for
plone.

This fixes:
plone/plone.app.discussion#66

Files changed:
M docs/source/howtos/howto_extend_the_comment_form.txt
M plone/app/discussion/__init__.py
M plone/app/discussion/browser/captcha.zcml
M plone/app/discussion/browser/comment.py
M plone/app/discussion/browser/comments.pt
M plone/app/discussion/browser/comments.py
M plone/app/discussion/browser/configure.zcml
M plone/app/discussion/browser/moderation.pt
M plone/app/discussion/comment.py
M plone/app/discussion/configure.zcml
M plone/app/discussion/contentrules.py
M plone/app/discussion/interfaces.py
M plone/app/discussion/notifications.zcml
M plone/app/discussion/permissions.zcml
M plone/app/discussion/subscribers.zcml
D plone/app/discussion/locales/update.sh
Repository: plone.app.discussion
Branch: refs/heads/master
Date: 2015-11-09T22:29:47+01:00
Author: Gil Forcada (gforcada) <gforcada@gnome.org>
Commit: plone/plone.app.discussion@dba633e

Update CHANGES

Files changed:
M CHANGES.rst
Repository: plone.app.discussion
Branch: refs/heads/master
Date: 2015-11-09T22:32:10+01:00
Author: Gil Forcada Codinachs (gforcada) <gil.forcada@freitag.de>
Commit: plone/plone.app.discussion@befff14

Merge pull request #74 from plone/remove-own-i18n-domain

Use plone i18n domain

Files changed:
M CHANGES.rst
M docs/source/howtos/howto_extend_the_comment_form.txt
M plone/app/discussion/__init__.py
M plone/app/discussion/browser/captcha.zcml
M plone/app/discussion/browser/comment.py
M plone/app/discussion/browser/comments.pt
M plone/app/discussion/browser/comments.py
M plone/app/discussion/browser/configure.zcml
M plone/app/discussion/browser/moderation.pt
M plone/app/discussion/comment.py
M plone/app/discussion/configure.zcml
M plone/app/discussion/contentrules.py
M plone/app/discussion/interfaces.py
M plone/app/discussion/notifications.zcml
M plone/app/discussion/permissions.zcml
M plone/app/discussion/subscribers.zcml
D plone/app/discussion/locales/update.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincentfretin vincentfretin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vincentfretin @tisto