Merge pull request #309 from plone/toolbar-icon-alt-tag

Remove alt tags from icons within links.
plone · May 20, 2022 · 6147620 · 6147620
2 parents 78b72a0 + 2586df6
commit 6147620
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/news/309.bugfix b/news/309.bugfix
@@ -0,0 +1,2 @@
+Remove alt tags from icons within links.
+[agitator]
diff --git a/plone/app/layout/viewlets/menu.pt b/plone/app/layout/viewlets/menu.pt
@@ -14,12 +14,12 @@
 
           <tal:if condition="python:actionid != 'history'">
             <tal:icon tal:condition="python:action['icon']"
-                      tal:replace="structure python:icons.tag(action['icon'] or 'toolbar-action', tag_alt=action['id'], tag_class='me-1')" />
+                      tal:replace="structure python:icons.tag(action['icon'] or 'toolbar-action', tag_class='me-1')" />
             <span class="toolbar-label" tal:content="action/title" i18n:translate="">View name</span>
           </tal:if>
 
           <tal:if tal:condition="python:actionid == 'history'">
-            <tal:icon tal:replace="structure python:icons.tag('lock' if locked else action['icon'], tag_alt=action['id'], tag_class='me-1')" />
+            <tal:icon tal:replace="structure python:icons.tag('lock' if locked else action['icon'], tag_class='me-1')" />
             <span class="toolbar-label">
               <time
                 class="pat-display-time"

diff --git a/plone/app/layout/viewlets/toolbar.pt b/plone/app/layout/viewlets/toolbar.pt
@@ -34,7 +34,7 @@
          data-bs-offset="0,0"
          aria-expanded="false"
          tal:attributes="href personal_bar/homelink_url">
-        <tal:icon tal:replace="structure python:icons.tag('toolbar-action/personaltools', tag_alt='portal-personaltools', tag_class='me-1')" />
+        <tal:icon tal:replace="structure python:icons.tag('toolbar-action/personaltools', tag_class='me-1')" />
         <span class="toolbar-label" tal:content="personal_bar/user_name">User</span>
       </a>
 
@@ -46,7 +46,7 @@
         </li>
         <li tal:repeat="action personal_bar/user_actions">
           <a href="${action/href}" class="dropdown-item">
-            <tal:icon replace="structure python:icons.tag(action.get('icon', 'dot'), tag_alt='portal-personaltools', tag_class='me-1')" />
+            <tal:icon replace="structure python:icons.tag(action.get('icon', 'dot'), tag_class='me-1')" />
             <tal:actionname tal:content="action/title">
               action title
             </tal:actionname>