Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alt tags from icons within links. #309

Merged
merged 2 commits into from May 20, 2022
Merged

Conversation

agitator
Copy link
Member

No description provided.

@mister-roboto
Copy link

@agitator thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@agitator
Copy link
Member Author

@jenkins-plone-org please run jobs

@agitator agitator requested a review from petschki May 19, 2022 21:10
@agitator
Copy link
Member Author

@jenkins-plone-org please run jobs

@jensens jensens merged commit 6147620 into master May 20, 2022
@jensens jensens deleted the toolbar-icon-alt-tag branch May 20, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants