Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cyclic dependency with Products.CMFPlone. #262

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

ericof
Copy link
Sponsor Member

@ericof ericof commented Sep 14, 2021

Fixes #261

@ericof ericof self-assigned this Sep 14, 2021
@mister-roboto
Copy link

@ericof thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@ericof
Copy link
Sponsor Member Author

ericof commented Sep 14, 2021

@jenkins-plone-org please run jobs

Copy link
Sponsor Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
One unrelated Jenkins failure.

@mauritsvanrees mauritsvanrees merged commit 47ff03c into master Sep 14, 2021
@mauritsvanrees mauritsvanrees deleted the issue-261-remove-cyclic-dependency branch September 14, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cyclic dependency with Products.CMFPlone
3 participants