Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove alt tags from icons within links. #309

Merged
merged 2 commits into from
May 20, 2022
Merged

Remove alt tags from icons within links. #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c668c72
Remove alt tags from icons within links.
agitator May 19, 2022
2586df6
add news
agitator May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/309.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Remove alt tags from icons within links.
[agitator]
4 changes: 2 additions & 2 deletions plone/app/layout/viewlets/menu.pt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@

<tal:if condition="python:actionid != 'history'">
<tal:icon tal:condition="python:action['icon']"
tal:replace="structure python:icons.tag(action['icon'] or 'toolbar-action', tag_alt=action['id'], tag_class='me-1')" />
tal:replace="structure python:icons.tag(action['icon'] or 'toolbar-action', tag_class='me-1')" />
<span class="toolbar-label" tal:content="action/title" i18n:translate="">View name</span>
</tal:if>

<tal:if tal:condition="python:actionid == 'history'">
<tal:icon tal:replace="structure python:icons.tag('lock' if locked else action['icon'], tag_alt=action['id'], tag_class='me-1')" />
<tal:icon tal:replace="structure python:icons.tag('lock' if locked else action['icon'], tag_class='me-1')" />
<span class="toolbar-label">
<time
class="pat-display-time"
Expand Down
4 changes: 2 additions & 2 deletions plone/app/layout/viewlets/toolbar.pt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
data-bs-offset="0,0"
aria-expanded="false"
tal:attributes="href personal_bar/homelink_url">
<tal:icon tal:replace="structure python:icons.tag('toolbar-action/personaltools', tag_alt='portal-personaltools', tag_class='me-1')" />
<tal:icon tal:replace="structure python:icons.tag('toolbar-action/personaltools', tag_class='me-1')" />
<span class="toolbar-label" tal:content="personal_bar/user_name">User</span>
</a>

Expand All @@ -46,7 +46,7 @@
</li>
<li tal:repeat="action personal_bar/user_actions">
<a href="${action/href}" class="dropdown-item">
<tal:icon replace="structure python:icons.tag(action.get('icon', 'dot'), tag_alt='portal-personaltools', tag_class='me-1')" />
<tal:icon replace="structure python:icons.tag(action.get('icon', 'dot'), tag_class='me-1')" />
<tal:actionname tal:content="action/title">
action title
</tal:actionname>
Expand Down