TinyMCE gets initialized twice

[frapell]

@datakurre Do you remember why this was needed here?

plone.app.mosaic/src/plone/app/mosaic/browser/static/js/mosaic.tile.js

Line 793 in b93b809

that.setupWysiwyg();

With latest TinyMCE (4.7.6) I'm observing that the toolbar won't open and I would get this error tinymce/tinymce#2655

For what I understand, TinyMCE loads asynchronously (was this not the case with previous versions?) and because of that line 793, a new pattern is created, but without properly cleaning up the previous initialization... even though there is code that should do that in

plone.app.mosaic/src/plone/app/mosaic/browser/static/js/mosaic.tile.js

Line 1013 in b93b809

$content.data("pattern-tinymce").destroy();

(I suspect because of tinymce being created async, however I don't quite understand why it was working before...)

Commenting out that line 793 solves the issue for me, and clicking on any of the richtext tiles would now show up the toolbar just fine...

Reading those "HACK HACK HACK" on top makes me think that this might have been something for old TinyMCE that is no longer needed, but I'm not sure...

[datakurre]

You are probably correct. Those lines are already years old. And it also works on older versions than your latest one? Thanks!

…

On 27 Mar 2018, 16.53 +0300, Franco Pellegrini ***@***.***>, wrote: Closed #407 via 0e5ce8c135b309d5ce051f399a265d93b80ef3be. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[frapell]

I haven't tested it yet, will do so shortly and if so, will submit a pull request with that stripped away