Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make search in "Language Shared" folder work #108

Closed
wants to merge 5 commits into from
Closed

Conversation

khink
Copy link
Member

@khink khink commented Jan 3, 2014

Fixes #106

When using the search viewlet, or the search form, the path parameter is a string, not a dictionary having a "query" key with a list of paths as a value.

We now check first to see if query['path'] is a string to make the search form work on the /shared folder also.

The first commit (Flake8) is also in #107.

When using the search viewlet, or the search form, the path
parameter is a string, not a dictionary having a "query" key with
a list of paths as a value.

We now check first to see if query['path'] is a string to make the
search form work on the /shared folder also.
@khink
Copy link
Member Author

khink commented Jan 3, 2014

Hang on, this is missing something.

@mauritsvanrees
Copy link
Sponsor Member

+1 from me for the implementation. Works fine.

I am not completely sure if this is wanted, because I am not too knowledgeable in plone.app.multilingual, but it makes sense to me.

@maethu
Copy link

maethu commented Mar 18, 2014

@mauritsvanrees
I asked the mailinglist if someone takes care for the 1.x branch.
But currently everyone works on the Plone 5 PAM release.

imho we need this feature and it also make sense to me.

@khink
Can you rebase your branch against 1.x? So we can merge it into 1.x branch.

Conflicts:
	docs/HISTORY.txt
	setup.py
	src/plone/app/multilingual/catalog.py
@khink
Copy link
Member Author

khink commented Mar 18, 2014

I just updated, so this can be merged.

(I cherry-picked the PEP8 commit directly on 1.x first, like i should have done in the first place: bd475eb Pull requests for PEP8, FLake8 and import ordering are just too much.)

Thanks all for taking the time to look into this!

@mauritsvanrees
Copy link
Sponsor Member

I have merged it manually to the 1.x branch. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants