navigation-, news-, recent-,review-portlets: add options to supress i… #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgrcon
force-pushed
the
plip1734thumbs
branch
2 times, most recently
from
bd80f7d
to
f528ae5
Compare
fgrcon
force-pushed
the
plip1734thumbs
branch
from
f528ae5
to
2662191
Compare
fgrcon
force-pushed
the
plip1734thumbs
branch
2 times, most recently
from
afc5e39
to
c70a131
Compare
16 tasks
fgrcon
force-pushed
the
plip1734thumbs
branch
5 times, most recently
from
a6476fa
to
fb69138
Compare
fgrcon
force-pushed
the
plip1734thumbs
branch
8 times, most recently
from
df30640
to
bef0d7c
Compare
…cons, read thumbsize from registry plus option to override thumbsize individually / or suppress thumbs. replace paper clip icon wqith mimetype icons for files plone/Products.CMFPlone#1734
ebrehault
reviewed
May 31, 2017
| @@ -1,6 +1,7 @@ | |||
| # -*- coding: utf-8 -*- | |||
| from Acquisition import aq_inner, aq_base, aq_parent | |||
| from ComputedAttribute import ComputedAttribute | |||
| from plone import api | |||
There was a problem hiding this comment.
After reading this comment from @jensens https://github.com/plone/plone.portlet.collection/pull/15/files#r110555223 I guess it is ok.
There was a problem hiding this comment.
@ebrehault I thought that the decision so far was to not allow plone.api in the core... I'm not much against it as long as the circular dependencies are taken care of 😓
There was a problem hiding this comment.
I think here it is not ok. I hate this, but as long we do not have a clear definition what is consumer and what is provider for plone.api we can not use it.
ebrehault
approved these changes
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cons, read thumbsize from registry plus option to override thumbsize individually / or suppress thumbs.
plone/Products.CMFPlone#1734