Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 32 - Collection not filtering integer field #33

Merged
merged 6 commits into from
Apr 27, 2015
Merged

Conversation

rodfersou
Copy link
Member

No description provided.

@@ -4,7 +4,8 @@ Changelog
1.3.2 (unreleased)
------------------

- Nothing changed yet.
- Fix collection not filtering integer field (closes `#32`_).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodfersou in fact what you did was to add 3 new operators because the current ones did not work as expected; please amend the changelog entry.

and this is a good place to use git rebase, BTW ;-)

@hvelarde
Copy link
Member

@tisto could you please tell us where to start the 1.2.x branch?

@tisto
Copy link
Sponsor Member

tisto commented Apr 27, 2015

777da1f

@hvelarde
Copy link
Member

@esteele @jensens @thet @tisto can you make a review of this and merge it?

do @rodfersou needs to add something to plone.app.ugrade for this?

same applies for #34

@jensens
Copy link
Sponsor Member

jensens commented Apr 27, 2015

with all plone 5 tests started here http://jenkins.plone.org/view/All/job/pull-request/98/

jensens added a commit that referenced this pull request Apr 27, 2015
Issue 32 - Collection not filtering integer field
@jensens jensens merged commit 3e800c9 into master Apr 27, 2015
@jensens
Copy link
Sponsor Member

jensens commented Apr 27, 2015

lets wait for jenkins and if the plone 5 build is fine i would say merge of #34 is fine too

@jensens jensens deleted the issue_32 branch April 27, 2015 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants