Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce IQueryModifier, refactor INavigationRoot stickyness. #65

Merged
merged 1 commit into from
Jul 25, 2016

Conversation

jensens
Copy link
Sponsor Member

@jensens jensens commented Jul 22, 2016

Refactor addition of criteria to stick inside INavigationRoot in querybuilder.
Added a simple IQueryModifier interfaces expecting a query and returning a query.
Iterates over all sorted utilities providing such an interfaces and calls it right before the query is parsed.
Code to add the INavigationRoot stickyness was moved to such a query modifier.

@agitator agitator merged commit fe08bce into master Jul 25, 2016
@agitator agitator deleted the feature-querymodifier branch July 25, 2016 16:25
@thet
Copy link
Member

thet commented Jul 25, 2016

Great! This would make the custom query injection obsolete and it's a better approach.
I guess, we just can't remove the custom query feature: #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants