Change user id generation, making it pluggable #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for the case when email is used as login. It checked that a changed email address was valid as user id. But the user id is never changed here, only the login name. We would get an error when changing an email address to for example pete_o'hara+hello@example.org. That one may look silly but is a fine email adddress and should be allowed, also for login. We only need to check if this address is not used by another user.
vipod
added a commit
that referenced
this pull request
Nov 29, 2012
Use schema tags to process ordering / filtering
'name' is the officially supported way according to the PAS interface.
…id and login_name.
|
No longer needed. PLIP 13419 is handling this more fully, and has already been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refs http://dev.plone.org/ticket/11616 which complains that not all valid email addresses are accepted as login name. This pull request does not really change that, but takes a different approach, changing the way user ids are chosen.