Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change user id generation, making it pluggable #5

Closed
wants to merge 9 commits into from
Closed

Change user id generation, making it pluggable #5

wants to merge 9 commits into from

Commits on Nov 7, 2012

  1. When using email as login, create a user id based on the full name. 

    This refs issue http://dev.plone.org/ticket/11616
    @mauritsvanrees
    mauritsvanrees committed Nov 7, 2012
    Configuration menu
    Copy the full SHA
    77d1ef9 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2012

  1. Add email login tests.

    @mauritsvanrees
    mauritsvanrees committed Nov 9, 2012
    Configuration menu
    Copy the full SHA
    4dbe4c7 View commit details
    Browse the repository at this point in the history

  2. Query IUserIdGenerator utility for generating a user id.

    @mauritsvanrees
    mauritsvanrees committed Nov 9, 2012
    Configuration menu
    Copy the full SHA
    6fa7786 View commit details
    Browse the repository at this point in the history

  3. history

    @mauritsvanrees
    mauritsvanrees committed Nov 9, 2012
    Configuration menu
    Copy the full SHA
    cc8b039 View commit details
    Browse the repository at this point in the history

  4. Test that a second 'Bob Jones' gets id 'bob-jones-1'

    @mauritsvanrees
    mauritsvanrees committed Nov 9, 2012
    Configuration menu
    Copy the full SHA
    425ef78 View commit details
    Browse the repository at this point in the history

  5. Fix email as login validation in UserDataPanel. 

    This is for the case when email is used as login.  It checked that a
changed email address was valid as user id.  But the user id is never
changed here, only the login name.  We would get an error when
changing an email address to for example
pete_o'hara+hello@example.org.  That one may look silly but is a fine
email adddress and should be allowed, also for login.  We only need to
check if this address is not used by another user.
    @mauritsvanrees
    mauritsvanrees committed Nov 9, 2012
    Configuration menu
    Copy the full SHA
    ccb04d3 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2013

  1. Call pas.searchUsers with name=email, instead of login=email. 

    'name' is the officially supported way according to the PAS interface.
    @mauritsvanrees
    mauritsvanrees committed Jan 3, 2013
    Configuration menu
    Copy the full SHA
    99ce0c1 View commit details
    Browse the repository at this point in the history

  2. Add ILoginNameGenerator and be clearer about difference between user_… 

    …id and login_name.
    @mauritsvanrees
    mauritsvanrees committed Jan 3, 2013
    Configuration menu
    Copy the full SHA
    dc3fd17 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2013

  1. Try pas.applyTransform in the personalize form as well.

    @mauritsvanrees
    mauritsvanrees committed Jan 4, 2013
    Configuration menu
    Copy the full SHA
    4732c0b View commit details
    Browse the repository at this point in the history