Skip to content

Commit

Permalink
Merge b0c4b85 into 22e6e15
Browse files Browse the repository at this point in the history
  • Loading branch information
thet committed Jun 28, 2017
2 parents 22e6e15 + b0c4b85 commit ef3b711
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 8 deletions.
8 changes: 5 additions & 3 deletions CHANGES.rst
Expand Up @@ -4,9 +4,11 @@ Changelog
1.10 (unreleased)
-----------------

- failsafe Unset and reset ``define`` and ``require``
[petschki]
- Insert ``++resource++plone.app.widgets.js`` resource at the beginning, before ``++resource++plone.app.jquery.js`` (but after ``++resource++plone.app.widgets-requirejs-unset.js``).
This makes other installations more predictable when they install resources directly after ``++resource++plone.app.jquery.js``.
[thet]


- PEP 8.
[thet]

Expand All @@ -17,7 +19,7 @@ Changelog
- Unset and reset ``define`` and ``require`` before and after the plone.app.widgets JavaScript bundle.
This avoids the infamous ``Mismatched anonymous define`` error with unbundled JavaScript supporting RequireJS.
See: http://requirejs.org/docs/errors.html#mismatch
[thet]
[thet, petschki]

- Remove Plone 5 specific zcml conditions
[petschki]
Expand Down
2 changes: 1 addition & 1 deletion plone/app/widgets/profiles/default/jsregistry.xml
Expand Up @@ -17,7 +17,7 @@

<javascript
id="++resource++plone.app.widgets.js"
insert-after="++resource++plone.app.jquery.js"
insert-before="*"
cacheable="True"
compression="none"
cookable="True"
Expand Down
4 changes: 2 additions & 2 deletions plone/app/widgets/static/requirejs-reset.js
@@ -1,2 +1,2 @@
if(typeof _old_define !== 'undefined') { var define = _old_define; }
if(typeof _old_require !== 'undefined') { var require = _old_require; }
define = typeof(_old_define) !== 'undefined' ? _old_define : undefined;
require = typeof(_old_require) !== 'undefined' ? _old_require : undefined;
4 changes: 2 additions & 2 deletions plone/app/widgets/static/requirejs-unset.js
@@ -1,4 +1,4 @@
if(typeof define !== 'undefined') { var _old_define = define; }
if(typeof require !== 'undefined') { var _old_require = require; }
if(typeof define !== 'undefined') { var _old_define = define; } else { var define; }
if(typeof require !== 'undefined') { var _old_require = require; } else { var require; }
define = undefined;
require = undefined;

0 comments on commit ef3b711

Please sign in to comment.