Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix lineage recursion (another attempt) #108

Open
wants to merge 3 commits into
base: master
from

Conversation

@ale-rt
Copy link
Member

ale-rt commented Jul 5, 2019

Alternative to #107

@mister-roboto

This comment has been minimized.

Copy link

mister-roboto commented Jul 5, 2019

@ale-rt thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@ale-rt

This comment has been minimized.

Copy link
Member Author

ale-rt commented Jul 5, 2019

@jenkins-plone-org please run jobs

@rpatterson

This comment has been minimized.

Copy link
Member

rpatterson commented Nov 21, 2019

This is plaguing all my Python 3 Plone testing work, so I'm eager to see this get worked out and merged. Here's some more discussion.

@ale-rt

This comment has been minimized.

Copy link
Member Author

ale-rt commented Nov 21, 2019

I am not 100% sure of the approach and recently @jensens introduced a similar caching mechanism in #114. I need to check if this is obsolete.
@rpatterson do you still face the recursion issue with plone.dexterity master?

@jensens

This comment has been minimized.

Copy link
Member

jensens commented Nov 21, 2019

In my opinion this one is obsolete now, but I may have missed something?

@ale-rt

This comment has been minimized.

Copy link
Member Author

ale-rt commented Nov 21, 2019

I think you are right, but need to double check
CC @cillianderoiste

@cdw9

This comment has been minimized.

Copy link
Member

cdw9 commented Nov 26, 2019

I still get the stack overflow on master, but have not yet seen it happen on this branch.

@cdw9

This comment has been minimized.

Copy link
Member

cdw9 commented Nov 26, 2019

@jenkins-plone-org please run jobs

@tkimnguyen

This comment has been minimized.

Copy link
Member

tkimnguyen commented Nov 27, 2019

I don't understand why the https://jenkins.plone.org/job/pull-request-5.2/711/ job is reported as having failed. The Robot Test Summary show 0 failures in the critical test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.