Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid an edge case where content types would end up without fields #166

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

frapell
Copy link
Sponsor Member

@frapell frapell commented Apr 19, 2022

This fixes gh-165

@mister-roboto
Copy link

@frapell thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@frapell
Copy link
Sponsor Member Author

frapell commented Apr 19, 2022

@jenkins-plone-org please run jobs

1 similar comment
@frapell
Copy link
Sponsor Member Author

frapell commented Apr 19, 2022

@jenkins-plone-org please run jobs

@frapell
Copy link
Sponsor Member Author

frapell commented Apr 19, 2022

An alternative to this fix (to not mess with the result of the _p_mtime) would be to change the replacements made by

class SchemaNameEncoder(object):
to not hit this issue...

@jensens
Copy link
Sponsor Member

jensens commented Jun 13, 2024

@jenkins-plone-org please run jobs

@jensens
Copy link
Sponsor Member

jensens commented Jun 14, 2024

Actually this one would be nice to get merged. I updated the branch, but I have no idea why this breaks tests in plone.restapi.

@frapell
Copy link
Sponsor Member Author

frapell commented Jun 14, 2024

@jensens Thanks for moving it forward! It's been so long I don't quite remember 😅 I'll try to take a look this weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content type schema has no fields based on FTI ._p_mtime
3 participants