Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale with srcset (aka retina) and height or width not set (and no scale given) fails. #56

Closed
jensens opened this issue Sep 8, 2017 · 0 comments
Closed

Scale with srcset (aka retina) and height or width not set (and no scale given) fails. #56

jensens opened this issue Sep 8, 2017 · 0 comments
Labels
01 type: bug 12 prio: high 21 status: confirmed

Comments

@jensens
Copy link
Sponsor Member

jensens commented Sep 8, 2017

If the srcset is generated, then a None value for height or width fails.
jensens added a commit that referenced this issue Sep 8, 2017
@jensens
add tests to show the problem of #56
5e71ee2
jensens added a commit that referenced this issue Sep 8, 2017
@jensens
fixes #56
9e132a0
@jensens jensens mentioned this issue Sep 8, 2017
Merged
@thet thet closed this as completed in a20f0c8 Sep 8, 2017
thet added a commit that referenced this issue Sep 8, 2017
@thet
Merge pull request #57 from plone/fix-56
bd6be27 
Fixes #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
01 type: bug 12 prio: high 21 status: confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jensens