Image caption support in Plone 5.1.x #38
Conversation
|
@tuticapi you need to sign the Plone Contributor Agreement in order to merge this pull request. Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html |
|
@tuticapi thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@tuticapi thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
I wonder if we can just latest plone.outputfilters in Plone 5.1. There wasn't changed too much. I'd prefer that than to have to maintain two seperate branches.
One thing to note: we're changing the templates here from using the <dl/dt/dd> to <figcaption>, which is a major change. Not sure if that's OK, but let's first test the whole thing.
|
@tuticapi I started a new jenkins run with these 3 PRs together: I didn't include the plone/plone.app.upgrade#232 because that would fail and is not necessary to check if all is still working on a fresh install. This is the jenkins run: https://jenkins.plone.org/job/pull-request-5.1/304/ |
|
Uhm. I recognized, I wanted to check with plone.outputfilter master :/ |
|
OK, next try. I created a buildout.coredev branch for 5.1 which depends on plone.outputfilters master/4.0.1: plone/buildout.coredev#658 Now a new Jenkins run with these PRs: (Side note: technically the mockup checkout doesn't do much because the tests don't build a JS bundle.) This is the Jenkins run: https://jenkins.plone.org/job/pull-request-5.1/305/ Let's see what happens. |
|
PR rejected. See: https://community.plone.org/t/image-captions-from-plone-5-1/12255/10 |
Change the image caption template to use <figure> and <figcaption>.
Add an ImageCaptioningEnabler utility which can be enabled via the portal registry setting plone.image_captioning.
Merge with:
plone/mockup#978
plone/Products.CMFPlone#3099
#38
plone/plone.app.upgrade#232