Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query registry once #64

Merged
merged 1 commit into from Jun 26, 2023
Merged

Query registry once #64

merged 1 commit into from Jun 26, 2023

Conversation

gotcha
Copy link
Member

@gotcha gotcha commented Jun 26, 2023

instead of querying it for each img tag.

@mister-roboto
Copy link

@gotcha thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@gotcha
Query registry once
b619daf 
instead of querying it for each img tag.
@gotcha gotcha force-pushed the avoid_useless_call_to_registry branch from d47479d to b619daf Compare June 26, 2023 13:03
@gotcha gotcha requested a review from MrTango June 26, 2023 13:16
MrTango
MrTango approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@MrTango MrTango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx

@gotcha
Copy link
Member Author

gotcha commented Jun 26, 2023

@MrTango Thx for the review. Am I supposed to merge myself ? What is the current best practice in Plone core repos ?

@MrTango
Copy link
Contributor

MrTango commented Jun 26, 2023

it's a small change, feel free to merge it. I'm not at the desk right now. as long as the test are running should be fine.

@gotcha gotcha merged commit e2043ba into master Jun 26, 2023
12 checks passed
@gotcha gotcha deleted the avoid_useless_call_to_registry branch June 26, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrTango MrTango MrTango approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gotcha @mister-roboto @MrTango