Fix for "ValueError: Attempted relative import in non-package" - In windows system

[fazalsulaiman]

No description provided.

[mister-roboto]

@fazalsulaiman thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

[fazalsulaiman]

@mauritsvanrees : Please review the change and merge the MR

[mauritsvanrees]

@jenkins-plone-org please run jobs

[mauritsvanrees]

Seems to make sense, but I cannot try it, so I prefer a second opinion from @jensens.
Feel free to merge in a day when there is no reaction.

[jensens]

LGTM - even I also did not try this. But if it works for @fazalsulaiman it should be fine.

[fazalsulaiman]

@jenkins-plone-org please run jobs

[mauritsvanrees]

I started the Jenkins jobs an hour ago, then you did the same half an hour later, and then a minute later you merged...
If jobs are already running, and there are no new changes, then please wait will the jobs are finished. This should be clear in the status checks, but it may take some getting used to.
And starting new jobs and then immediately merging, is not very useful.

Anyway, I checked the jobs that I started and they were all green, so it's okay. But in my part of the world it is hot enough already: we don't need extra heat generated by a server running those jobs. ;-)

But thanks for working on Windows issues! Great to have more people who care about that!

[jugmac00]

@mauritsvanrees While the plone contributing process is much more streamlined than most others I know, isn't it possible to restrict merging to successfully tested branches?

This would take away some burden from new contributors to go through a pretty long mental checklist.

[jensens]

Sure, this is possible, but we need to add the protected branches for every single repository in Plone, that's quite annoying. I added master branch protection for this repository now.

[jugmac00]

This should be possible via API, but at 35 ° C it is preferable to go to beach and keep the status quo 😉

[fazalsulaiman]

I started the Jenkins jobs an hour ago, then you did the same half an hour later, and then a minute later you merged...
If jobs are already running, and there are no new changes, then please wait will the jobs are finished. This should be clear in the status checks, but it may take some getting used to.
And starting new jobs and then immediately merging, is not very useful.

Anyway, I checked the jobs that I started and they were all green, so it's okay. But in my part of the world it is hot enough already: we don't need extra heat generated by a server running those jobs. ;-)

But thanks for working on Windows issues! Great to have more people who care about that!

Thank you @mauritsvanrees for the details and I will follow that