Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic repoze.profile integration #129

Merged
merged 5 commits into from
May 10, 2021
Merged

Conversation

jensens
Copy link
Sponsor Member

@jensens jensens commented Sep 12, 2019

Basic integration of repoze.profile to allow easy profiling of requests in Zope4.

Todo:

  • manual check if profiling works
  • check if cachegrind output works (KCachegrind loads the fine)
  • check if all options are working
  • fix/ create tests

@mister-roboto
Copy link

@jensens thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@jensens jensens force-pushed the jensens-repoze.profile-integration branch from b0056d9 to 8f25081 Compare September 22, 2020 13:10
@jensens jensens force-pushed the jensens-repoze.profile-integration branch from 8f25081 to c16f74e Compare March 16, 2021 14:28
@jensens jensens force-pushed the jensens-repoze.profile-integration branch from 6fb7c4d to 4f5f25b Compare May 10, 2021 09:36
@jensens jensens force-pushed the jensens-repoze.profile-integration branch from 4f5f25b to 6743490 Compare May 10, 2021 15:30
@jensens
Copy link
Sponsor Member Author

jensens commented May 10, 2021

@jenkins-plone-org please run jobs

@jensens jensens marked this pull request as ready for review May 10, 2021 16:02
@jensens
Copy link
Sponsor Member Author

jensens commented May 10, 2021

@jenkins-plone-org please run jobs

@jensens jensens requested review from tschorr and sneridagh May 10, 2021 20:38
Copy link
Member

@thet thet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thet thet merged commit 614afe4 into master May 10, 2021
@thet thet deleted the jensens-repoze.profile-integration branch May 10, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants